Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/RA-TLS] Drop deprecated RA_TLS_* env semantics #1870

Merged
merged 1 commit into from
May 7, 2024

Conversation

mkow
Copy link
Member

@mkow mkow commented May 4, 2024

Description of the changes

Omitting any of the measurement variables is now a hard error.

How to test this PR?

Try RA-TLS examples without setting some of these variables.


This change is Reviewable

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link
Contributor

@oshogbo oshogbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Omitting any of the measurement variables is now a hard error.

Signed-off-by: Michał Kowalczyk <mkow@invisiblethingslab.com>
@mkow mkow force-pushed the mkow/drop-deprecated-stuff-2 branch from fe75e8d to b7ffa83 Compare May 7, 2024 00:52
Copy link
Contributor

@kailun-qin kailun-qin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dimakuv dimakuv merged commit b7ffa83 into master May 7, 2024
18 checks passed
@dimakuv dimakuv deleted the mkow/drop-deprecated-stuff-2 branch May 7, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants