This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Fix manifests for Bash #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice fix. Can you rebase to current master so that CI passes? Also, would you mind adding some unit tests to our CI scripts for bash so that bash doesn't regress? |
|
I'm a little confused about the wrong exec file commit; is that still active? |
|
@donporter No. I wanted to see it fails on Graphene-SGX Jenkins test with old wrong configuration. |
|
This PR is ready to be merged |
|
Test this please |
2 similar comments
|
Test this please |
|
Test this please |
donporter
approved these changes
Mar 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes configuration errors when running Bash on SGX.