Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

[CI] Add back gitignore-test to all configurations #1971

Merged
merged 1 commit into from Nov 17, 2020

Conversation

pwmarcz
Copy link
Contributor

@pwmarcz pwmarcz commented Nov 16, 2020

Removed by mistake in abe3d77.


This change is Reviewable

dimakuv
dimakuv previously approved these changes Nov 16, 2020
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)

@mkow mkow requested a review from woju November 16, 2020 14:47
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @pwmarcz and @woju)

a discussion (no related file):
In the commit message, could you change the commit hash to commit one-liner? We still need to edit the commit history at some point to drop those binary blobs which take 700MB :/ (which will change all the hashes)


Copy link
Contributor Author

@pwmarcz pwmarcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @mkow and @woju)

a discussion (no related file):

Previously, mkow (Michał Kowalczyk) wrote…

In the commit message, could you change the commit hash to commit one-liner? We still need to edit the commit history at some point to drop those binary blobs which take 700MB :/ (which will change all the hashes)

Done.


mkow
mkow previously approved these changes Nov 16, 2020
Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)

dimakuv
dimakuv previously approved these changes Nov 16, 2020
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required) (waiting on @woju)

woju
woju previously approved these changes Nov 16, 2020
Copy link
Member

@woju woju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @woju)

@dimakuv dimakuv dismissed stale reviews from woju, mkow, and themself via 40dcc54 November 17, 2020 07:13
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)

@dimakuv
Copy link
Contributor

dimakuv commented Nov 17, 2020

Jenkins, retest Jenkins-Debug-18.04 please (select04 LTP test failed)

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @pwmarcz)

a discussion (no related file):
Oops, we merged something in the meantime that gitignore-test complains about:

              ERROR: Files modified by build, but not gitignored:
--------------------------------------------------------------------------------
?? LibOS/shim/test/regression/pthread_set_get_affinity
?? LibOS/shim/test/regression/sched_set_get_affinity

@pwmarcz Could you amend this PR to git-ignore these files? (Add them in LibOS/shim/test/regression/.gitignore)


Copy link
Contributor Author

@pwmarcz pwmarcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @dimakuv)

a discussion (no related file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Oops, we merged something in the meantime that gitignore-test complains about:

              ERROR: Files modified by build, but not gitignored:
--------------------------------------------------------------------------------
?? LibOS/shim/test/regression/pthread_set_get_affinity
?? LibOS/shim/test/regression/sched_set_get_affinity

@pwmarcz Could you amend this PR to git-ignore these files? (Add them in LibOS/shim/test/regression/.gitignore)

Done, let's see if Jenkins passes now.


@dimakuv
Copy link
Contributor

dimakuv commented Nov 17, 2020

Jenkins, retest Jenkins-SGX-18.04 please (poll_closed_fd LibOS test failed; IIUC, this will be fixed by Borys's #1949)

@dimakuv
Copy link
Contributor

dimakuv commented Nov 17, 2020

Jenkins, retest Jenkins-SGX-18.04 please (poll_closed_fd LibOS test failed; IIUC, this will be fixed by Borys's #1949б second time already...)

Removed by mistake in "[LibOS] test/ltp: Upgrade LTP to 20200930".

Also add two files that have been merged without gitignore in the
meantime.
woju
woju previously approved these changes Nov 17, 2020
Copy link
Member

@woju woju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)

dimakuv
dimakuv previously approved these changes Nov 17, 2020
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

@dimakuv dimakuv dismissed stale reviews from woju and themself via 5ba4708 November 17, 2020 13:42
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)

Copy link
Member

@woju woju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link
Member

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@boryspoplawski boryspoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dimakuv dimakuv merged commit 5ba4708 into gramineproject:master Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants