Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

[Pal/Linux-SGX] tools: Support upstreamed driver in is_sgx_available #2438

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

mkow
Copy link
Member

@mkow mkow commented Jun 12, 2021

Description of the changes

Seems we forgot to update this tool after SGX got into the kernel. Kudos to @vans163 for noticing this!

Closes #2427.

How to test this PR?

Run is_sgx_available on a system which uses the upstreamed SGX driver and check if "SGX driver loaded" says "true".


This change is Reviewable

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @mkow)

a discussion (no related file):
Please add that this PR closes #2427


Copy link
Member Author

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv)

a discussion (no related file):

Previously, dimakuv (Dmitrii Kuvaiskii) wrote…

Please add that this PR closes #2427

Done.


dimakuv
dimakuv previously approved these changes Jun 14, 2021
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)

Signed-off-by: Michał Kowalczyk <mkow@invisiblethingslab.com>
@mkow mkow force-pushed the mkow/support-upstreamed-driver-in-is_sgx_available branch from 0b9eafb to b52bd10 Compare June 18, 2021 09:19
Copy link
Contributor

@dimakuv dimakuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dimakuv dimakuv merged commit b52bd10 into master Jun 18, 2021
@dimakuv dimakuv deleted the mkow/support-upstreamed-driver-in-is_sgx_available branch June 18, 2021 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants