Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update react, typescript and jest #84

Merged
merged 9 commits into from
Sep 9, 2022
Merged

update react, typescript and jest #84

merged 9 commits into from
Sep 9, 2022

Conversation

opudalo
Copy link
Contributor

@opudalo opudalo commented Jun 25, 2022

No description provided.

@oleksiilevzhynskyi
Copy link
Collaborator

Hi @opudalo. Thank you for your contribution!

A bit of context for React 18 and Focal. Focal still use the old lifecycle API. It's not a blocker, but this isn't compatible with React async mode in Suspense. @KatSick working on migration (#82)

Anyway, your PR looks ok to me. Going to double-check if it works on my side and release it in a few days or so.

@opudalo
Copy link
Contributor Author

opudalo commented Jul 21, 2022

Hello guys, any update on this?

cc @oleksiilevzhynskyi, @Wenqer

@oleksiilevzhynskyi oleksiilevzhynskyi merged commit 33556b9 into grammarly:master Sep 9, 2022
@opudalo opudalo deleted the update-deps branch September 9, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants