Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation? #1

Closed
TineUser opened this issue Mar 1, 2021 · 3 comments
Closed

Documentation? #1

TineUser opened this issue Mar 1, 2021 · 3 comments

Comments

@TineUser
Copy link

TineUser commented Mar 1, 2021 •
edited
Loading

Hi all,

I'm interested in testing Grammm in my home lab. But I don't find any documention about the requirements of Grammm and how to install it.

Can you provide the documentation, please?

Thank You.
@TineUser
Copy link
Author

TineUser commented Mar 2, 2021

Thanks to MrKeksi, I got the documentation I didn't find: https://docs.grammm.com/admin/quickstart.html

@TineUser
Copy link
Author

TineUser commented Mar 2, 2021 •
edited
Loading

This documentation is very new (01.03.2021) and incomplete. But OK, there is few information where to get the ISO of the appliance and about the requirements. So I was able to install the appliance as virtual machine and could install nano and open-vm-tools.

@cmpalm
Copy link
Member

cmpalm commented Mar 2, 2021

This repository is for the Gromox component only. Its documentation is in a rather aptly named directory, equally so the install.rst file.
2

@cmpalm cmpalm closed this as completed Mar 2, 2021
jengelh added a commit that referenced this issue Mar 18, 2021
@jengelh @cmpalm
all: fix 45 instances of unchecked return values / 3 TOCTOU
c996761 
CID 1443849 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)24.
check_return: Calling remove(pstream->path) without checking return value. This
library function may fail and return an error code.

CID 1441376
CID 1441393
CID 1441430
CID 1441452
CID 1441476
CID 1441488
CID 1441521
CID 1441523
CID 1441549
CID 1441565
CID 1441571
CID 1441594
CID 1441599
CID 1441613
CID 1441625
CID 1441689
CID 1441698
CID 1441724
CID 1441737
CID 1441757
CID 1442371
CID 1442389
CID 1442410
CID 1442411
CID 1442456
CID 1442465
CID 1442466
CID 1442468
CID 1442473
CID 1442482
CID 1442485
CID 1442512
CID 1442530
CID 1442592
CID 1442594
CID 1442606
CID 1442615
CID 1442625
CID 1442631
CID 1442651
CID 1442672
CID 1442691
CID 1442697
CID 1442698
CID 1442731
CID 1442751
CID 1442774
CID 1443849
jengelh pushed a commit that referenced this issue Mar 22, 2021
@fcneuf
exmdb_provider: fix 2 instances of FORWARD_NULL
52302bf 
CID 1441797 (#1 of 1): Dereference after null check (FORWARD_NULL)
26. var_deref_op: Dereferencing null pointer ptable_ids.

CID 1442618
jengelh pushed a commit that referenced this issue Mar 22, 2021
@fcneuf
moh_nsp: fix 2 instances of FORWARD_NULL
30d4206 
CID 1448406 (#1 of 1): Dereference after null check (FORWARD_NULL)
9. var_deref_model: Passing null pointer presponse->poutmids to
ab_ext_push_mid_array, which dereferences it.

CID 1448410
jengelh pushed a commit that referenced this issue Mar 22, 2021
@fcneuf
misc: fix 6 instances of NULL_RETURNS
ab07460 
CID 1441656 (#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing pref, which is known to be nullptr.

CID 1441656
CID 1442502
CID 1443817
CID 1445883
CID 1445901
CID 1446017
jengelh added a commit to gromox/gromox that referenced this issue Apr 1, 2021
@jengelh @cmpalm
all: fix 45 instances of unchecked return values / 3 TOCTOU
cda7314 
CID 1443849 (grommunio#1 of 1): Unchecked return value from library (CHECKED_RETURN)24.
check_return: Calling remove(pstream->path) without checking return value. This
library function may fail and return an error code.

CID 1441376
CID 1441393
CID 1441430
CID 1441452
CID 1441476
CID 1441488
CID 1441521
CID 1441523
CID 1441549
CID 1441565
CID 1441571
CID 1441594
CID 1441599
CID 1441613
CID 1441625
CID 1441689
CID 1441698
CID 1441724
CID 1441737
CID 1441757
CID 1442371
CID 1442389
CID 1442410
CID 1442411
CID 1442456
CID 1442465
CID 1442466
CID 1442468
CID 1442473
CID 1442482
CID 1442485
CID 1442512
CID 1442530
CID 1442592
CID 1442594
CID 1442606
CID 1442615
CID 1442625
CID 1442631
CID 1442651
CID 1442672
CID 1442691
CID 1442697
CID 1442698
CID 1442731
CID 1442751
CID 1442774
CID 1443849
jengelh pushed a commit to gromox/gromox that referenced this issue Apr 1, 2021
@fcneuf
exmdb_provider: fix 2 instances of FORWARD_NULL
fd8ed2d 
CID 1441797 (grommunio#1 of 1): Dereference after null check (FORWARD_NULL)
26. var_deref_op: Dereferencing null pointer ptable_ids.

CID 1442618
jengelh pushed a commit to gromox/gromox that referenced this issue Apr 1, 2021
@fcneuf
misc: fix 6 instances of NULL_RETURNS
ff7d15a 
CID 1441656 (grommunio#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing pref, which is known to be nullptr.

CID 1441656
CID 1442502
CID 1443817
CID 1445883
CID 1445901
CID 1446017
jengelh added a commit that referenced this issue Apr 11, 2021
@jengelh @cmpalm
all: fix 45 instances of unchecked return values / 3 TOCTOU
a610926 
CID 1443849 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)24.
check_return: Calling remove(pstream->path) without checking return value. This
library function may fail and return an error code.

CID 1441376
CID 1441393
CID 1441430
CID 1441452
CID 1441476
CID 1441488
CID 1441521
CID 1441523
CID 1441549
CID 1441565
CID 1441571
CID 1441594
CID 1441599
CID 1441613
CID 1441625
CID 1441689
CID 1441698
CID 1441724
CID 1441737
CID 1441757
CID 1442371
CID 1442389
CID 1442410
CID 1442411
CID 1442456
CID 1442465
CID 1442466
CID 1442468
CID 1442473
CID 1442482
CID 1442485
CID 1442512
CID 1442530
CID 1442592
CID 1442594
CID 1442606
CID 1442615
CID 1442625
CID 1442631
CID 1442651
CID 1442672
CID 1442691
CID 1442697
CID 1442698
CID 1442731
CID 1442751
CID 1442774
CID 1443849
jengelh pushed a commit that referenced this issue Apr 11, 2021
@fcneuf
exmdb_provider: fix 2 instances of FORWARD_NULL
84508ff 
CID 1441797 (#1 of 1): Dereference after null check (FORWARD_NULL)
26. var_deref_op: Dereferencing null pointer ptable_ids.

CID 1442618
jengelh pushed a commit that referenced this issue Apr 11, 2021
@fcneuf
misc: fix 6 instances of NULL_RETURNS
e4fa079 
CID 1441656 (#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing pref, which is known to be nullptr.

CID 1441656
CID 1442502
CID 1443817
CID 1445883
CID 1445901
CID 1446017
jengelh added a commit that referenced this issue Apr 11, 2021
@jengelh @cmpalm
all: fix 45 instances of unchecked return values / 3 TOCTOU
c8fdee4 
CID 1443849 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)24.
check_return: Calling remove(pstream->path) without checking return value. This
library function may fail and return an error code.

CID 1441376
CID 1441393
CID 1441430
CID 1441452
CID 1441476
CID 1441488
CID 1441521
CID 1441523
CID 1441549
CID 1441565
CID 1441571
CID 1441594
CID 1441599
CID 1441613
CID 1441625
CID 1441689
CID 1441698
CID 1441724
CID 1441737
CID 1441757
CID 1442371
CID 1442389
CID 1442410
CID 1442411
CID 1442456
CID 1442465
CID 1442466
CID 1442468
CID 1442473
CID 1442482
CID 1442485
CID 1442512
CID 1442530
CID 1442592
CID 1442594
CID 1442606
CID 1442615
CID 1442625
CID 1442631
CID 1442651
CID 1442672
CID 1442691
CID 1442697
CID 1442698
CID 1442731
CID 1442751
CID 1442774
CID 1443849
jengelh pushed a commit that referenced this issue Apr 11, 2021
@fcneuf
exmdb_provider: fix 2 instances of FORWARD_NULL
3c80685 
CID 1441797 (#1 of 1): Dereference after null check (FORWARD_NULL)
26. var_deref_op: Dereferencing null pointer ptable_ids.

CID 1442618
jengelh pushed a commit that referenced this issue Apr 11, 2021
@fcneuf
misc: fix 6 instances of NULL_RETURNS
0eed176 
CID 1441656 (#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing pref, which is known to be nullptr.

CID 1441656
CID 1442502
CID 1443817
CID 1445883
CID 1445901
CID 1446017
jengelh pushed a commit that referenced this issue Apr 16, 2021
@juliaschroeder @grammmike
exmdb_provider: fix unchecked return value
e62e36d 
CID 1442407 (#1 of 1): Unchecked return value (CHECKED_RETURN)
8. check_return: Calling sqlite3_step without checking return
value (as is done elsewhere 592 out of 594 times).
jengelh pushed a commit that referenced this issue Apr 16, 2021
@juliaschroeder
exmdb_provider: fix unchecked return value in exmdb_server_load_messa…
2374c56 
…ge_instance

CID 1443841 (#1 of 1): Unchecked return value (CHECKED_RETURN)
9. check_return: Calling tpropval_array_set_propval without checking
return value (as is done elsewhere 467 out of 500 times).

Fix calling tpropval_array_set_propval without checking return value.
Fixed by aborting the function and releasing resources.
jengelh pushed a commit that referenced this issue Apr 16, 2021
@juliaschroeder
exmdb_provider: fix unused value in exmdb_server_query_table
101f705 
CID 1442452 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value 1718747167U (0x6672001f) to proptag
here, but that stored value is overwritten before it can be used.
jengelh pushed a commit that referenced this issue Apr 16, 2021
all: fix 13 instances of unchecked return values / TOCTOU
e341073 
CID 1441393 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)
19. check_return: Calling rename(temp_path, g_aliasaddress_path)
without checking return value. This library function may fail and
return an error code.

CID 1441393
CID 1441487
CID 1441660
CID 1441798
CID 1442651
CID 1442731
CID 1442774
CID 1451993
CID 1452584
CID 1452587
CID 1452592
CID 1446010
CID 1442751
jengelh added a commit that referenced this issue Apr 16, 2021
@jengelh @fcneuf
imap: pass full buffer size to sprintf
8eed74c 
Unsure what the background is for this CID, but it could be that
x[127] is left undefined.

CID 1442660 (#1 of 1): Copy of overlapping memory (OVERLAPPING_COPY)
20. overlapping_copy: In the call to function snprintf, the object pointed
to by argument pcontext->mid may overlap with the object pointed to by
argument pcontext->file_path.
jengelh added a commit that referenced this issue Apr 16, 2021
@jengelh @fcneuf
exchange_nsp: resolve some copy-paste flagged code
46b54c1 
CID 1448392 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR)
copy_paste_error: res_and in pfilter->res.res_and.cres looks
like a copy-paste error.
jengelh added a commit that referenced this issue Apr 16, 2021
@jengelh @fcneuf
imap: clear ineffective unsigned comparison
49715a2 
CID 1452586 (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This greater-than-or-equal-to-zero comparison
of an unsigned value is always true. len >= 0UL.
jengelh added a commit that referenced this issue Apr 16, 2021
@jengelh @fcneuf
ldap_adaptor: fix incorrect comparison
eb927c2 
CID 1441636 (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned value is never true. conn_num < 0U.
jengelh added a commit that referenced this issue Apr 16, 2021
@jengelh @fcneuf
lib: remove ineffective unsigned comparison
d1668e8 
CID 1452270 (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an
unsigned value is never true. index < 0UL.

CID 1452270
CID 1452757
jengelh added a commit that referenced this issue Apr 16, 2021
@jengelh @fcneuf
lib/mapi: fix possible unsigned underflow
05a96ba 
CID 1450851 (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This greater-than-or-equal-to-zero comparison
of an unsigned value is always true. i >= 0UL.
jengelh added a commit that referenced this issue Apr 18, 2021
@jengelh @grammmike
lib: fix 2 instances of TOCTOU in bounce_producer_load_subdir
6452d8e 
CID 1452276 (#1 of 1): Time of check time of use (TOCTOU)
33. fs_check_call: Calling function stat to perform check on sub_buff.

CID 1452276
CID 1452278
jengelh added a commit that referenced this issue Apr 18, 2021
@jengelh @grammmike
rebuild: fix an instance of TOCTOU
bddb1ef 
CID 1441510 (#1 of 1): Time of check time of use (TOCTOU)
4. fs_check_call: Calling function stat to perform check on "temp_path".
42. toctou: Calling function remove that uses temp_path after a check
function. This can cause a time-of-check, time-of-use race condition.

It is a false positive, since stat() is merely used to see if there
is anything to do. However, access() is a better fit.
jengelh added a commit that referenced this issue Apr 18, 2021
@jengelh @grammmike
tools: fix 3 instances of TOCTOU
5d48d84 
CID 1441689 (#1 of 1): Time of check time of use (TOCTOU)
4. fs_check_call: Calling function stat to perform check on "temp_path".
42. toctou: Calling function remove that uses temp_path after a check
function. This can cause a time-of-check, time-of-use race condition.
[sic]

The TOCTOU occurs with the stat–sqlite3_open_v2 pair actually, not so
much stat–chmod.

CID 1441584
CID 1441689
CID 1441757
jengelh added a commit that referenced this issue Sep 22, 2023
@jengelh
src: resolve cov-scan warnings
4cd5106 
CID 1521557 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
4. var_deref_op: Dereferencing null pointer props.ppropval.
[Cannot happen. False positive.]

CID 1521562 (#3 of 3): Assignment of overlapping memory (OVERLAPPING_COPY)
6. overlapping_assignment: Assigning u.u8 to u.u16, which have overlapping
memory locations and different types. [No consequence. False positive.]

CID 1521561 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)
CID 1521559 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)
identical_branches: Ternary expression on condition logon->is_private() has
identical then and else expressions.

CID 1518246 (#1 of 2): Logically dead code (DEADCODE)
jengelh pushed a commit to gromox/gromox that referenced this issue Oct 18, 2023
@fcneuf
zcore: plug memory leak involving oxcmail_import
2a2901a 
CID 1522454 (grommunio#1 of 1): Resource leak (RESOURCE_LEAK)
9. leaked_storage: Variable pmsgctnt going out of scope leaks the
storage it points to.
jengelh pushed a commit that referenced this issue Oct 21, 2023
@fcneuf
exmdb: resolve potential nullptr deref in cu_rcpt_to_list
8b99c25 
CID 1522451 (#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing a pointer that might be nullptr str
when calling strcasecmp.

Fixes: gromox-2.14-28-g87a21d155
jengelh pushed a commit that referenced this issue Oct 21, 2023
@fcneuf
imap: remove some unused code from imap_parser_run
bb8eb8e 
CID 1522452 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value 800 to num here, but that stored
value is overwritten before it can be used.
jengelh pushed a commit that referenced this issue Nov 18, 2023
@fcneuf
midb: resolve cov-scan warnings
f81fa4c 
CID 1524312 (#1 of 1): Uninitialized scalar variable (UNINIT)
7. uninit_use: Using uninitialized value folder_id.

Fixes: gromox-2.17-23-g24e7d57eb
jengelh pushed a commit that referenced this issue Nov 18, 2023
@fcneuf
edb2mt: resolve cov-scan warnings
b458ae0 
CID 1523710 (#2 of 2): Unchecked return value (CHECKED_RETURN)
10. check_return: Calling set without checking return value (as is
done elsewhere 475 out of 490 times)
CID 1523708 (#1 of 1): Structurally dead code (UNREACHABLE)
unreachable: This code cannot be reached: return gromox::errno_t(0);.
jengelh pushed a commit that referenced this issue Nov 27, 2023
@fcneuf
mapi_lib: resolve cov-scan warnings "COPY_INSTEAD_OF_MOVE"
460860f 
CID 1527669 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527675 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527678 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527679 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527681 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527682 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527683 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527689 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527693 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527694 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527701 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527704 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527705 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527706 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527714 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527717 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
1. copy_constructor_call: id2user is passed-by-value as parameter to
cvt_entryid_to_smtpaddr when it could be moved instead.
jengelh pushed a commit that referenced this issue Nov 27, 2023
@fcneuf
misc: resolve cov-scan warnings "AUTO_CAUSES_COPY"
8249bc7 
CID 1527658 (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY) [false-pos]
CID 1527661 (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY) [false-pos]
CID 1527677 (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY) [false-pos]
CID 1527680 (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY) [false-pos]
CID 1527691 (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY) [ok]
CID 1527692 (#1 of 1): Use of auto that causes a copy
(AUTO_CAUSES_COPY) [false-pos]
auto_causes_copy: Using the auto keyword without an & causes the copy of an
object of type std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> >. [false-pos]
CID 1527710 (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY) [false-pos]
CID 1527712 (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY) [false-pos]
CID 1527713 (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY) [false-pos]
jengelh pushed a commit that referenced this issue Nov 27, 2023
@fcneuf
misc: resolve cov-scan warnings "COPY_INSTEAD_OF_MOVE"
99e7b64 
CID 1527662 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
1. copy_constructor_call: pconfig is passed-by-value as parameter to
midb_agent_reload when it could be moved instead.
CID 1527668 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527672 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
CID 1527698 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
1. copy_assignment_call: parent is copied in a call to copy
assignment operator =, when it could be moved instead
CID 1527711 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
jengelh pushed a commit that referenced this issue Nov 27, 2023
@fcneuf
lib: remove g_log_direct variable from logger
e0fd8b4 
CID 1527685 (#1 of 1): Check of thread-shared field evades lock
acquisition (LOCK_EVASION)
6. thread1_overwrites_value_in_field: Thread1 sets g_log_direct to a
new value. Now the two threads have an inconsistent view of
g_log_direct and updates to fields correlated with g_log_direct may
be lost.
jengelh pushed a commit that referenced this issue Nov 27, 2023
@fcneuf
smtp: resolve OOB write in HELO/EHLO/LHLO
2836499 
CID 1528537 (#1 of 1): Out-of-bounds write (OVERRUN)
CID 1528538 (#1 of 1): Out-of-bounds write (OVERRUN)
6. overrun-local: Overrunning array pcontext->menv.hello_domain of
255 bytes at byte offset 255 using index line_length - 5 (which
evaluates to 255).
jengelh added a commit that referenced this issue Dec 12, 2023
@jengelh
ews: resolve 2 cov-scan warnings
79a529e 
CID 1530685 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
CID 1530686 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
pass_by_value: Passing parameter fb_event of type freebusy_event
(size 152 bytes) by value, which exceeds the low threshold of 128
bytes.
jengelh added a commit that referenced this issue Jan 17, 2024
@jengelh
delivery: resolve cov-scan warnings
9d977bf 
CID 1533238: (#1 of 1): Uninitialized pointer read (UNINIT)
7. uninit_use_in_call: Using uninitialized value last_hook when
calling push_back.

Fixes: gromox-2.21-19-g63852fb03
jengelh added a commit to gromox/gromox that referenced this issue Feb 8, 2024
@jengelh
oxdisco: resolve 1 cov-scan warning
3dfe5b6 
CID 1534384: (grommunio#1 of 1): Dereference after null check (FORWARD_NULL)
6. dereference: Attempting to access the managed object of an empty
smart pointer c.

Fixes: gromox-2.22-21-g5e912166e
jengelh pushed a commit that referenced this issue Feb 24, 2024
@grammmike
email_lib: resolve cov-scan warnings for variable move
c19df25 
CID 1533984: (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
1. copy_constructor_call: m is passed-by-value as parameter to cu_send_vmail
when it could be moved instead.
jengelh added a commit that referenced this issue Mar 2, 2024
@jengelh
exmdb: resolve 1 cov-scan warning
9ce61d2 
32. no_write_call: Although exmdb_ext_pull_request does overwrite
request on some paths, it also contains at least one feasible
path which does not overwrite it.
CID 1534890: (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
33. dereference: Attempting to access the managed object of an
empty smart pointer request.
jengelh pushed a commit that referenced this issue Mar 6, 2024
@juliaschroeder @jengelh
ews: fix unsigned compared against 0
96adc69 
Remove redundant boundary checks.

CID 1534888: (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned value
is never true. dayOfWeekIndex < 0.
jengelh pushed a commit that referenced this issue Mar 28, 2024
@fcneuf @jengelh
exmdb: resolve cov-scan warnings for cu_get_replmap()
874eda6 
CID 1540837: (#1 of 2): Unchecked return value (CHECKED_RETURN)
5. check_return: Calling from_str without checking return value
(as is done elsewhere 11 out of 13 times).
CID 1540839: (#5 of 5): Unchecked return value (CHECKED_RETURN)
5. check_return: Calling p_uint16 without checking return value
(as is done elsewhere 131 out of 151 times).
CID 1540840: (#5 of 5): Unchecked return value (CHECKED_RETURN)
5. check_return: Calling p_guid without checking return value (as
is done elsewhere 117 out of 131 times).

Fixes: gromox-2.26-41-g7165fe988
jengelh pushed a commit that referenced this issue Mar 28, 2024
@fcneuf
imap: resolve cov-scan warnings in imap_cmd_parser_process_fetch_item()
67b87ee 
CID 1540838: (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking pmime suggests that it may be null,
but it has already been dereferenced on all paths leading to the
check.

Fixes: gromox-2.26-59-g1d0fa3b75
jengelh pushed a commit that referenced this issue Mar 28, 2024
@fcneuf
misc: resolve CHECKED_RETURN cov-scan warnings
b455668 
CID 1530681: (#1 of 1): Unchecked return value from library (CHECKED_RETURN)
18. check_return: Calling remove(tmp_path1) without checking return
value. This library function may fail and return an error code.
CID 1534875: (#1 of 1): Unchecked return value (CHECKED_RETURN)
4. check_return: Calling get_store_properties without checking return
value (as is done elsewhere 8 out of 10 times).
jengelh pushed a commit that referenced this issue Mar 28, 2024
@fcneuf
exch: silence cov-scan warnings about exmdb_parser/zrpc_parser
bd2f4d0 
A buffer of 4G size is possible, but unlikely, so use 0xffffffff as a
magic value to test for to soothe cov-scan.

CID 1452588: (#1 of 1): Untrusted allocation size (TAINTED_SCALAR)
CID 1452590: (#1 of 1): Untrusted allocation size (TAINTED_SCALAR)
5. tainted_data: Passing tainted expression buff_len to malloc, which uses it as an allocation size.
jengelh pushed a commit that referenced this issue Mar 31, 2024
@fcneuf
exmdb: resolve cov-scan warnings
f0a463e 
CID 1542788: (#1 of 1): Unchecked return value (CHECKED_RETURN)
11. check_return: Calling exec without checking return value (as is
done elsewhere 60 out of 62 times).
CID 1542787: (#1 of 1): Unchecked return value (CHECKED_RETURN)
CID 1542789: (#1 of 1): Unchecked return value (CHECKED_RETURN)
CID 1542792: (#1 of 1): Unchecked return value (CHECKED_RETURN)
3. check_return: Calling eph_exec without checking return value (as
is done elsewhere 41 out of 45 times).
CID 1540837: (#2 of 2): Unchecked return value (CHECKED_RETURN)
24. check_return: Calling from_str without checking return value (as
is done elsewhere 11 out of 13 times).

1 false positive:

33. null_check: Calling request == std::nullptr_t() implies that ``request``
might be null-like.
CID 1542791: (#1 of 1): Dereference after null check (FORWARD_NULL)
36. dereference: Attempting to access the managed object of an empty smart
pointer request.
jengelh pushed a commit that referenced this issue Mar 31, 2024
@fcneuf
ews: resolve cov-scan warnings
7dfe543 
CID 1528811: (#1 of 1): Unchecked return value (CHECKED_RETURN)
9. check_return: Calling set without checking return value (as is
done elsewhere 23 out of 24 times).
jengelh added a commit that referenced this issue May 9, 2024
@jengelh
exch: resolve 2 cov-scan warnings
12953b8 
CID 1544900: (#1 of 1): Use of auto that causes a copy (AUTO_CAUSES_COPY)
auto_causes_copy: Using the auto keyword without an & causes the copy
of an object of type std::string.

CID 1544901: (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
32. uninit_member: Non-static class member write_response is not
initialized in this constructor nor in any functions that it calls.
jengelh added a commit that referenced this issue Jun 21, 2024
@jengelh
exch: resolve 1 cov-scan warning
29dd851 
CID 1544901: (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
32. uninit_member: Non-static class member write_response is not
initialized in this constructor nor in any functions that it calls.
jengelh added a commit that referenced this issue Aug 13, 2024
@jengelh
emsmdb: resolve cov-scan warning about return type mismatches
613e148 
3. function_return: Function
emsmdb_interface_register_push_notification() returns -2147221246.
4. known_value_assign: out->result =
emsmdb_interface_register_push_notification(...), its value is now
-2147221246.
CID 1558754: (#1 of 1): Overflowed constant (INTEGER_OVERFLOW)
5. overflow_const: Expression *ecode, which is equal to -2147221246,
where out->result is known to be equal to -2147221246, overflows the
type that receives it, an unsigned integer 32 bits wide.
jengelh added a commit that referenced this issue Aug 13, 2024
@jengelh
exmdb_local: switch cache queue to use an atomic unsigned counter
c2ccf8e 
CID 1558659: (#1 of 1): Data race condition (MISSING_LOCK)
3. missing_lock: Accessing g_mess_id without holding lock g_id_lock.
Elsewhere, g_mess_id is written to with g_id_lock held 2 out of 3
times.
jengelh added a commit that referenced this issue Aug 13, 2024
@jengelh
exch: use full locking even during single-thread startup/shutdown
4a095ec 
What all amounts to single-threaded scenarios:

CID 1527697: (#1 of 1): Data race condition (MISSING_LOCK)
3. missing_lock: Accessing g_notify_hash[abi:cxx11] without holding
lock g_notify_lock. Elsewhere, g_notify_hash[abi:cxx11] is written to
with g_notify_lock held 4 out of 5 times.
CID 1527719: (#1 of 1): Data race condition (MISSING_LOCK)
3. missing_lock: Accessing g_logon_hash[abi:cxx11] without holding
lock g_hash_lock. Elsewhere, g_logon_hash[abi:cxx11] is written to
with g_hash_lock held 2 out of 3 times.
CID 1558583: (#1 of 1): Data race condition (MISSING_LOCK)
8. missing_lock: Accessing g_hash_table[abi:cxx11] without holding
lock g_hash_lock. Elsewhere, g_hash_table[abi:cxx11] is written to
with g_hash_lock held 2 out of 3 times.
CID 1558584: (#1 of 1): Data race condition (MISSING_LOCK)
3. missing_lock: Accessing g_user_hash[abi:cxx11] without holding
lock g_lock. Elsewhere, g_user_hash[abi:cxx11] is written to with
g_lock held 3 out of 4 times.
CID 1558602: (#1 of 1): Data race condition (MISSING_LOCK)
8. missing_lock: Accessing g_populating_list[abi:cxx11] without
holding lock g_list_lock. Elsewhere, g_populating_list[abi:cxx11] is
written to with g_list_lock held 2 out of 3 times.
CID 1558604: (#1 of 1): Data race condition (MISSING_LOCK)
2. missing_lock: Accessing g_notify_table[abi:cxx11] without holding
lock g_notify_lock. Elsewhere, g_notify_table[abi:cxx11] is written
to with g_notify_lock held 3 out of 4 times.
CID 1558626: (#1 of 1): Data race condition (MISSING_LOCK)
2. missing_lock: Accessing g_hash_table[abi:cxx11] without holding
lock g_hash_lock. Elsewhere, g_hash_table[abi:cxx11] is written to
with g_hash_lock held 6 out of 7 times.
CID 1558648: (#1 of 1): Data race condition (MISSING_LOCK)
2. missing_lock: Accessing g_user_table[abi:cxx11] without holding
lock g_table_lock. Elsewhere, g_user_table[abi:cxx11] is written to
with g_table_lock held 3 out of 4 times.
CID 1558677: (#1 of 1): Data race condition (MISSING_LOCK)
3. missing_lock: Accessing g_handle_hash without holding lock g_lock.
Elsewhere, g_handle_hash is written to with g_lock held 5 out of 6
times.
CID 1558730: (#1 of 1): Data race condition (MISSING_LOCK)
2. missing_lock: Accessing g_session_table without holding lock
g_table_lock. Elsewhere, g_session_table is written to with
g_table_lock held 3 out of 4 times.

Partially legit:

CID 1558622: (#1 of 1): Data race condition (MISSING_LOCK)
13. missing_lock: Accessing prouter->datagram_list without holding
lock ROUTER_CONNECTION.lock. Elsewhere,
ROUTER_CONNECTION.datagram_list is written to with
ROUTER_CONNECTION.lock held 3 out of 4 times.
jengelh added a commit that referenced this issue Aug 13, 2024
@jengelh
exmdb: add missing locking
1b07dc5 
CID 1558619: (#1 of 1): Data race condition (MISSING_LOCK)
2. missing_lock: Accessing g_connection_list without holding lock
g_connection_lock. Elsewhere, g_connection_list is written to with
g_connection_lock held 3 out of 3 times.
CID 1558641: (#1 of 1): Data race condition (MISSING_LOCK)
2. missing_lock: Accessing g_used_list without holding lock
g_used_mutex. Elsewhere, g_used_list is written to with g_used_mutex
held 2 out of 3 times.
jengelh added a commit that referenced this issue Sep 7, 2024
@jengelh
tests: resolve memleak in oxcmail_ie
ed04562 
CID 1559998: (#1 of 1): Resource leak (RESOURCE_LEAK)
6. leaked_storage: Variable mc going out of scope leaks the storage it points to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmpalm @TineUser