Do not handle commands from channels #147
Conversation
| (ctx): ctx is CommandContext<C> => { | ||
| const msg = ctx.message ?? ctx.channelPost; | ||
| const txt = msg.text ?? msg.caption; | ||
| const entities = msg.entities ?? msg.caption_entities; |
There was a problem hiding this comment.
This not only removes support for commands in channels but also for commands on media messages with captions?
Not sure if that even works normally, never tried that.
There was a problem hiding this comment.
grammY used to support commands in captions in its early days, but a lot of people in the community complained that it is not intuitive for command handlers to trigger when e.g. an image caption contains a command. Hence, the support was remove by changing the filter query from ::bot_command to :entities:bot_command.
The code that was removed here was essentially dead code.
There was a problem hiding this comment.
Mix? Do you mean merge?
Were commands handled in channels before? |
|
Oh well. I tested this once again, and interestingly enough the entities are not rendered in any client, but bots receive them. Hence, the assumption that the server does not parse the command entities in channels is wrong. As a result, we cannot drop this feature without doing a breaking change. I will close this unmerged. Note that if you still want bot.on('message').command('start', ctx => {
const name = ctx.from.first_name // `ctx.from` is present now!
}) |
|
The dead code you mentioned about the commands on captions should still be removed I guess? |
They don't exist anyway (the server does not parse the command entities in channels) so we might as well drop this.
#108 will add command handling that does not rely on parsed entities.
This PR has the advantage that
ctx.fromwill now always be present afterbot.command.