New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: try using a well-known deno_cache for automated web bundle #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit. Also, please don't mess with the version numbers :D
Does this fix out previous problem? In other words, should it close #343? |
Co-authored-by: KnorpelSenf <shtrog@gmail.com>
Codecov ReportBase: 36.93% // Head: 36.93% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
=======================================
Coverage 36.93% 36.93%
=======================================
Files 17 17
Lines 4364 4364
Branches 157 157
=======================================
Hits 1612 1612
Misses 2750 2750
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I guess we will only truly know when we let GH Action run it. But at the very least, locally, this setup no longer produces any additional write permission prompts. |
Let me rephrase: were missing write permissions what caused the error? |
But well, we can merge this before #343 and just try. Today is the day of patch releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYSM!
It could be the case that bundling fails as the tightly restricted list of directory for
--allow-write
meant that deno could not write to deno cache, as it is not specified.This PR attempts to specify a well-known path for deno cache so that it can be specified in the list of directory for
--allow-write
, in an attempt to resolve the current build error.