Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try using a well-known deno_cache for automated web bundle #344

Merged
merged 4 commits into from Dec 27, 2022

Conversation

KnightNiwrem
Copy link
Contributor

@KnightNiwrem KnightNiwrem commented Dec 27, 2022

It could be the case that bundling fails as the tightly restricted list of directory for --allow-write meant that deno could not write to deno cache, as it is not specified.

This PR attempts to specify a well-known path for deno cache so that it can be specified in the list of directory for --allow-write, in an attempt to resolve the current build error.

@KnightNiwrem KnightNiwrem changed the title Try using a well-known deno_cache for web bundle Try using a well-known deno_cache for automated web bundle Dec 27, 2022
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit. Also, please don't mess with the version numbers :D

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@KnorpelSenf
Copy link
Member

Does this fix out previous problem? In other words, should it close #343?

KnightNiwrem and others added 2 commits December 28, 2022 00:45
Co-authored-by: KnorpelSenf <shtrog@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Base: 36.93% // Head: 36.93% // No change to project coverage 👍

Coverage data is based on head (b1af957) compared to base (2678048).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   36.93%   36.93%           
=======================================
  Files          17       17           
  Lines        4364     4364           
  Branches      157      157           
=======================================
  Hits         1612     1612           
  Misses       2750     2750           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KnightNiwrem
Copy link
Contributor Author

KnightNiwrem commented Dec 27, 2022

Does this fix out previous problem? In other words, should it close #343?

I guess we will only truly know when we let GH Action run it. But at the very least, locally, this setup no longer produces any additional write permission prompts.

@KnorpelSenf
Copy link
Member

Let me rephrase: were missing write permissions what caused the error?

@KnorpelSenf
Copy link
Member

But well, we can merge this before #343 and just try. Today is the day of patch releases.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM!

package.json Outdated Show resolved Hide resolved
@KnorpelSenf KnorpelSenf changed the title Try using a well-known deno_cache for automated web bundle chore: try using a well-known deno_cache for automated web bundle Dec 27, 2022
@KnorpelSenf KnorpelSenf merged commit 0cbe645 into main Dec 27, 2022
@KnorpelSenf KnorpelSenf deleted the well-known-cache-dir branch December 27, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants