Implements grammyjs/menu#26 #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnorpelSenf
requested changes
Oct 4, 2022
Comment on lines
+205
to
+207
| url?: MaybeDynamicString<C>; | ||
| switch_inline_query?: MaybeDynamicString<C>; | ||
| switch_inline_query_current_chat?: MaybeDynamicString<C>; |
There was a problem hiding this comment.
This is not necessary, these things are already present in the types.
Comment on lines
+772
to
+778
| btn.url = btn.url && (await uniform(ctx, btn.url)) | ||
| btn.switch_inline_query = | ||
| btn.switch_inline_query && | ||
| (await uniform(ctx, btn.switch_inline_query_current_chat)) | ||
| btn.switch_inline_query_current_chat = | ||
| btn.switch_inline_query_current_chat && | ||
| (await uniform(ctx, btn.switch_inline_query_current_chat)) |
There was a problem hiding this comment.
You are setting these values on the object even when the properties are absent. This is undesired. Have a look at how middleware is handled, and replicate this pattern:
if("url" in btn") {
// ...
}
|
Are you still working on this? |
|
I'm closing this due to inactivity. Please reopen if you ever feel like continuing your work. It was a good start. If anyone else is interested in picking this up, please leave a quick comment, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26