Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config for docsearch plugin #511

Merged
merged 7 commits into from Nov 30, 2022
Merged

Update config for docsearch plugin #511

merged 7 commits into from Nov 30, 2022

Conversation

quadratz
Copy link
Contributor

@quadratz quadratz commented Sep 20, 2022 •
edited

@github-actions
Copy link

github-actions bot commented Sep 20, 2022 •
edited

🚀 Deployed on https://63876d600881947543c47d23--grammy.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 20, 2022 13:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 20, 2022 13:26 Inactive
KnorpelSenf
KnorpelSenf approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

For translation, only the commit 1313198 is relevant.

@KnorpelSenf KnorpelSenf added ready for translation Translator intervention is required. 🇮🇩 ID labels Sep 20, 2022
roj1512
roj1512 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@roj1512 roj1512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good relief.

@WingLim WingLim added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label Sep 24, 2022
@WingLim
Copy link
Collaborator

WingLim commented Sep 24, 2022

Great job!

@WingLim
Copy link
Collaborator

WingLim commented Sep 24, 2022

There is a question, I am translating #505 , where should I put the Fly entry in the menu? Just wait for this PR merged?

@KnorpelSenf
Copy link
Member

I suggest you put it in the same place as English and Indonesian do it right now, after Heroku and before GCF. Someone will deal with the merge conflicts for all languages at the same time.

@habemuscode
Copy link
Collaborator

Required sync with main again due to changes in config.ts merged @CikiMomogi

@quadratz quadratz marked this pull request as draft October 26, 2022 07:21
@quadratz quadratz removed ready for translation Translator intervention is required. 🇨🇳 ZH Modifies or is related to the Chinese translations. labels Oct 26, 2022
@quadratz
Copy link
Contributor Author

Please wait until #533 is merged.

habemuscode
habemuscode previously approved these changes Oct 26, 2022
View reviewed changes
@habemuscode habemuscode added ready for translation Translator intervention is required. 🇪🇸 ES Modifies or is related to the Spanish translations. labels Oct 26, 2022
@habemuscode
Copy link
Collaborator

Bot features link was missing, it's in other PR that probably will be merged before

@quadratz
Copy link
Contributor Author

quadratz commented Oct 26, 2022 •
edited

Yes. That's something I'm aware of. That is why I am temporarily closing this PQ and will merge them when they are ready.

@quadratz quadratz removed the ready for translation Translator intervention is required. label Oct 26, 2022
@quadratz quadratz removed the 🇪🇸 ES Modifies or is related to the Spanish translations. label Oct 26, 2022
@github-actions github-actions bot temporarily deployed to pull request November 29, 2022 15:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 29, 2022 15:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 29, 2022 15:22 Inactive
@quadratz quadratz marked this pull request as ready for review November 29, 2022 15:23
@quadratz quadratz added the ready for translation Translator intervention is required. label Nov 29, 2022
roj1512
roj1512 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@roj1512 roj1512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much!

@habemuscode habemuscode added the 🇪🇸 ES Modifies or is related to the Spanish translations. label Nov 30, 2022
@github-actions github-actions bot temporarily deployed to pull request November 30, 2022 14:49 Inactive
@roj1512 roj1512 merged commit dea3924 into main Nov 30, 2022
@roj1512 roj1512 deleted the docsearch branch November 30, 2022 18:20
@quadratz quadratz mentioned this pull request Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WingLim WingLim WingLim approved these changes

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

@habemuscode habemuscode habemuscode approved these changes

@roj1512 roj1512 roj1512 approved these changes

Assignees
No one assigned
Labels
🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID ready for translation Translator intervention is required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@quadratz @WingLim @KnorpelSenf @habemuscode @roj1512