Do not round rotation in SVG #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Sep 29, 2020
gramps/plugins/docgen/svgdrawdoc.py
Outdated
| @@ -128,7 +128,7 @@ def rotate_text(self, style, text, x, y, angle, mark=None): | |||
| self.buffer.write( | |||
| '<text ' + | |||
| 'x="%4.2f" y="%4.2f" ' % (xpos, ypos) + | |||
| 'transform="rotate(%d %4.2f %4.2f)" ' % (angle, centerx, centery) + | |||
| 'transform="rotate(%4.2 %4.2f %4.2f)" ' % (angle, centerx, centery) + | |||
There was a problem hiding this comment.
I think you mean:
Suggested change
| 'transform="rotate(%4.2 %4.2f %4.2f)" ' % (angle, centerx, centery) + | |
| 'transform="rotate(%4.2f %4.2f %4.2f)" ' % (angle, centerx, centery) + |
There was a problem hiding this comment.
Yes I did, thanks for checking! I amended the commit with the extra f.
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
=======================================
Coverage 41.28% 41.28%
=======================================
Files 1060 1060
Lines 143397 143397
=======================================
Hits 59204 59204
Misses 84193 84193
Continue to review full report at Codecov.
|
When making >8 generation fan charts, the rounding of rotation becomes visible. SVG does not force rotation to be integers, so better not round this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making >8 generation fan charts, the rounding of rotation becomes visible. SVG does not force rotation to be integers, so better not round this.