Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to set locale.textdomain under linux #1198

Merged
merged 2 commits into from Apr 13, 2021
Merged

Conversation

romjerome
Copy link
Contributor

_build_popup_ui() ignores translated strings without locale.textdomain set.

_build_popup_ui() ignores translated strings without locale.textdomain set.
@romjerome
Copy link
Contributor Author

@jralls
I do not know if we need to set locale.textdomain
under MacOS too, for avoiding a specific issue
around context menu on Editors (Person, Family).

See also bug report 12278.

@romjerome romjerome added this to the v5.1 milestone Apr 12, 2021
@romjerome romjerome added the bug label Apr 12, 2021
@jralls
Copy link
Member

jralls commented Apr 12, 2021

@romjerome This does set the text domain for macOS, the conditional is if not sys.platform == 'win32' and macOS isn't win32.

@romjerome
Copy link
Contributor Author

@jralls
Sorry, as the proposal makes the change for macOS too, I just wonder if this issue was specific to linux or both OS should have the fix. I do not have a macOS available now for testing...
macOS could have a specific handling for GLib's g_dgettext wrapper (or so) and only linux os should have the fix.
I just want to avoid a bug for macos users in relation with this section.

Copy link
Member

@jralls jralls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romjerome, there's very little macOS customization in glib. I tested on macOS: It does have the problem and this fixes it.

@romjerome
Copy link
Contributor Author

Thanks!
I will commit the change and close BR12278

@romjerome romjerome merged commit c8fc88c into maintenance/gramps51 Apr 13, 2021
@romjerome romjerome deleted the BR12278 branch April 13, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants