Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression option on XML export #121

Merged
merged 1 commit into from Apr 26, 2016
Merged

Add compression option on XML export #121

merged 1 commit into from Apr 26, 2016

Conversation

dsblank
Copy link
Member

@dsblank dsblank commented Apr 20, 2016

The write options needed to include "binary" to allow the system to write to the stream.

@dsblank
Copy link
Member Author

dsblank commented Apr 20, 2016

See https://gramps-project.org/bugs/view.php?id=9394 for details.

@Paul-Franklin
Copy link
Contributor

Yes, like you said on 9394 I don't think this should be committed
until it's checked on all three platforms.

@dsblank
Copy link
Member Author

dsblank commented Apr 20, 2016

I should also note that if one doesn't have the gzip Python library, the old module would crash with the same error that this fixes. That is, if this doesn't work, then we would have to create a different way of making .gramps files with no compression.

@sam-m888
Copy link
Member

Worked on Windows 7 Pro 64bit using Gramps 5.0.0 [13b4f93 + pr121] AIO 64 bit(Personal Testing version)

*Exported uncompressed
*Imported uncompressed

checkbox-selection-uncompressed-xml-pr121-b9394-win764bit

@dsblank dsblank merged commit 542dad0 into master Apr 26, 2016
@dsblank
Copy link
Member Author

dsblank commented Apr 26, 2016

Applied this, as we need it for further development. If there are issues on Mac, we will need to fix them.

@sam-m888 sam-m888 deleted the xml-compress branch April 26, 2016 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants