Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Family timeline error when dates are not Gregorian #1322

Closed

Conversation

SNoiraud
Copy link
Member

@SNoiraud SNoiraud commented Jan 6, 2022

Fixes #12525

@SNoiraud SNoiraud added the bug label Jan 6, 2022
@SNoiraud SNoiraud added this to the v5.1 milestone Jan 6, 2022
@Nick-Hall
Copy link
Member

Both arguments of a Span are already converted to the Gregorian calendar. See line 80 in the date code. I'm not sure why this fix necessary.

@Nick-Hall Nick-Hall changed the title Family timeline error when dates are not gregorian Family timeline error when dates are not Gregorian Jan 28, 2022
@SNoiraud
Copy link
Member Author

Both arguments of a Span are already converted to the Gregorian calendar. See line 80 in the date code. I'm not sure why this fix necessary.

Yes, I saw that but when we have a french republican date in one event, this is not done. I think we have the same problem when we have different calendars in the event list.

@Nick-Hall
Copy link
Member

@SNoiraud The actual bug was with the way the dates were being swapped for negative spans. The swapped dates were taken from the unconverted parameters. I have created PR #1332 with an alternative fix. Please test if you have time, but it works for me.

@SNoiraud SNoiraud closed this Jan 30, 2022
@SNoiraud SNoiraud deleted the frenchdate branch March 21, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants