Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for added symbol on Hourglass Report #1339

Merged
merged 1 commit into from Jul 24, 2023
Merged

Add option for added symbol on Hourglass Report #1339

merged 1 commit into from Jul 24, 2023

Conversation

khrys63
Copy link
Contributor

@khrys63 khrys63 commented Feb 14, 2022

A new option for Hourglass report

@khrys63
Copy link
Contributor Author

khrys63 commented Feb 14, 2022

image

for this result :

image

@Nick-Hall
Copy link
Member

This enhancement needs to use the Symbols class.


datesymbol = BooleanOption(_("Add Symbol for date"), False) # 10826
datesymbol.set_help(
_("Add a symbol for date. o for birth, + for decease and x for wedding."))

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea,
English is not my best language :)

@wroldwiedbwe
Copy link

wroldwiedbwe commented Feb 14, 2022

This enhancement needs to use the Symbols class.

As @Nick-Hall mentioned use the the symbols from the built in "Genealogical Symbols" option that the user selects instead of the ones you have hard-coded.

https://gramps-project.org/wiki/index.php/Gramps_5.1_Wiki_Manual_-_Settings#Genealogical_Symbols

@khrys63
Copy link
Contributor Author

khrys63 commented Feb 14, 2022

You might also want to use the the symbols from the built in "Genealogical Symbols" option that the user selects instead of the ones you have hard-coded?

https://gramps-project.org/wiki/index.php/Gramps_5.1_Wiki_Manual_-_Settings#Genealogical_Symbols

I use this list : https://geneafinder.com/blog?id=13:113 or https://fr.geneawiki.com/index.php/Symboles_de_g%C3%A9n%C3%A9alogie
birth : o or *
decease : +
marriage : X or oo

what is the real standard?

@wroldwiedbwe
Copy link

what is the real standard?

No real standard, have a read of https://www.tamurajones.net/GenealogySymbols.xhtml

datesymbol.set_help(
_("Add a symbol for date. o for birth, + for decease and x for wedding."))
_("Add a symbol for date. o for birth, + for deceased and x for marriage."))

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @wroldwiedbwe English phrasing is correct ; as you are not adding a date and only showing a symbol beside the three event types.

@khrys63 Haven't tested, but hopefully the symbols don't show if the events don't exist or are blank?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with last commit it's good :)

image

@khrys63
Copy link
Contributor Author

khrys63 commented Feb 15, 2022

image

@SNoiraud
Copy link
Member

SNoiraud commented Mar 7, 2022

Is it really useful to have an option ?
In the preferences symbols tab, we have the possibility to use or not the symbols.
If we don't use the symbols, we can define the replacement characters.

@Nick-Hall
Copy link
Member

@SNoiraud The option is useful because there are two formats: (1 jan 1900 - 2 Feb 1950) and (* 1 jan 1900 + 2 Feb 1950).

I'm getting some problems with the example database though:

Garner, Joseph (* 1792 ✝ )
Daniels, Phoebe (* )

@Nick-Hall Nick-Hall added the string Requires string changes label Jul 14, 2023
@Nick-Hall
Copy link
Member

Rebased and made some minor changes to the text.

@Nick-Hall Nick-Hall merged commit fde2e18 into gramps-project:master Jul 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement string Requires string changes
Projects
None yet
5 participants