New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for added symbol on Hourglass Report #1339
Conversation
This enhancement needs to use the |
gramps/plugins/graph/gvhourglass.py
Outdated
|
||
datesymbol = BooleanOption(_("Add Symbol for date"), False) # 10826 | ||
datesymbol.set_help( | ||
_("Add a symbol for date. o for birth, + for decease and x for wedding.")) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice idea,
English is not my best language :)
As @Nick-Hall mentioned use the the symbols from the built in "Genealogical Symbols" option that the user selects instead of the ones you have hard-coded.
|
I use this list : https://geneafinder.com/blog?id=13:113 or https://fr.geneawiki.com/index.php/Symboles_de_g%C3%A9n%C3%A9alogie what is the real standard? |
No real standard, have a read of https://www.tamurajones.net/GenealogySymbols.xhtml |
gramps/plugins/graph/gvhourglass.py
Outdated
datesymbol.set_help( | ||
_("Add a symbol for date. o for birth, + for decease and x for wedding.")) | ||
_("Add a symbol for date. o for birth, + for deceased and x for marriage.")) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @wroldwiedbwe English phrasing is correct ; as you are not adding a date and only showing a symbol beside the three event types.
@khrys63 Haven't tested, but hopefully the symbols don't show if the events don't exist or are blank?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really useful to have an option ? |
@SNoiraud The option is useful because there are two formats: (1 jan 1900 - 2 Feb 1950) and (* 1 jan 1900 + 2 Feb 1950). I'm getting some problems with the example database though: Garner, Joseph (* 1792 ✝ ) |
Rebased and made some minor changes to the text. |
A new option for Hourglass report