Replace deprecated imp by importlib #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nick-Hall, as part of this PR, I replaced the Ubuntu 18.04 image for the unit tests with 20.04, as 18.04 is no longer supported by Github: |
|
Thanks. I see that 18.04 was removed on 12th Jan. I'll probably cherry-pick that commit immediately. |
|
Code added to Gramps 5.1 is required to work with python 3.3, so I'll merge this into the master branch only. |
Nick-Hall
added
Code Quality
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impis deprecated and will be removed in Python 3.12, to be released this year.The code I added will work with Python 3.4 and up, which is enough four Gramps 5.1 and up.
Could also be cherry-picked into the 5.1 maintenance branch.