Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cite plugin from "Default" to "Legacy" #1563

Conversation

DaveSch-gramps
Copy link
Contributor

Make the displayed name more descriptive

'Author, "Title", Publisher, (Abbreviation)'

@Nick-Hall Nick-Hall changed the title Update cite.gpr.py Rename cite plugin from "Default" to "Legacy" Sep 2, 2023
@Nick-Hall
Copy link
Member

You also need to update po/POTFILES.in and gramps/gen/config.py.

@emyoulation
Copy link
Contributor

@Nick-Hall Nick-Hall force-pushed the Change-default-citation-display-name branch from 75774f5 to add81a6 Compare September 3, 2023 16:00
@Nick-Hall Nick-Hall merged commit add81a6 into gramps-project:maintenance/gramps52 Sep 3, 2023
2 checks passed
@DaveSch-gramps DaveSch-gramps deleted the Change-default-citation-display-name branch September 3, 2023 20:39
@emyoulation
Copy link
Contributor

Should the cite-default label in the configuration file be changed to cite-legacy?
register("preferences.cite-plugin", "cite-default")

https://github.com/Nick-Hall/gramps/blob/6f98fa07fcea15f9bcaaaacba6860b3382646294/gramps/gen/config.py#L334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants