Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Gramps to run from an extracted source distribution #1688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmichault
Copy link
Contributor

When trying to run gramps directly from sources extracted from tar.gz file, gramps don't run :

$ python3 Gramps.py
ResourcePath.ERROR: Unable to determine resource path

This is because gramps is testing for the existence of the ".git" folder, which does not exist in the sources extracted from the tar.gz file.

I suggest testing for the existence of the "data" folder, which exists both in the sources obtained by "git clone" and those extracted from tar.gz.

@Nick-Hall
Copy link
Member

The problem is that it is possible for a package called "data" to exist in the site-packages directory. A check for the MANIFEST.in file would be safer.

Please rebase this on the master branch. It is not a bug.

@Nick-Hall Nick-Hall changed the title allow to run from sources Allow Gramps to run from an extracted source distribution Mar 23, 2024
@Nick-Hall
Copy link
Member

As a workaround, run the command touch .git to create an empty file.

@jmichault jmichault changed the base branch from maintenance/gramps52 to master March 24, 2024 10:12
@jmichault jmichault closed this Mar 24, 2024
@jmichault jmichault reopened this Mar 24, 2024
@jmichault
Copy link
Contributor Author

All right.
Pull request rebased, and test changed for MANIFEST.in

@Nick-Hall
Copy link
Member

That should be safer. There is a project called data, but calling a project "MANIFEST.in" is unlikely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants