Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Occupation in rel_graph #64

Closed
wants to merge 2 commits into from
Closed

Conversation

fobrice
Copy link

@fobrice fobrice commented Sep 10, 2015

This patch is for the rel_graph plugin

It add the possibility to include the last occupation (when available) of each person in the graph.

Fabrice

@Paul-Franklin
Copy link
Contributor

I don't have a machine I can run this on, at the moment,
but just from looking at the code I wonder why you have
code which includes the gramps-id, when you are testing
for self.occupation?

@fobrice
Copy link
Author

fobrice commented Sep 11, 2015

Sorry Paul, it was a mistake: I had bad interpretation of the code.

I have commit a new code.

Fabrice

@Paul-Franklin
Copy link
Contributor

I plan to commit this to gramps, although I have positioned
your occupation line slightly lower, in both the result and the
options dialog, as well as adding parentheses around the
occupation, as that is how that report seems to do things.

You didn't include a copyright line, with your name (and
email address as you are not a regular developer), so
I would appreciate it if you let me know. You can email
it to me if you don't want to post it here (I guess Google
knows how to find me, but I don't like to post it).

As you may or may not know, there are at least two
"feature requests" for this enhancement. Also, of
course I will commit it only to "master" (as opposed
to gramps42) since all enhancements go there.

Thank you for helping make gramps better.

@fobrice
Copy link
Author

fobrice commented Sep 15, 2015

Thank you Paul! You can add a line "Contributions by Fabrice fobrice at laposte dot net"

Fabrice

@Paul-Franklin
Copy link
Contributor

It is very confusing adding comments here on github.

Their system is adding them in places I never expected.

However, I want to credit you (and this pull request) for
5a5e7a2
which will be in gramps 5.0.0 -- thanks.

@sam-m888
Copy link
Member

Closing as already merged.

@sam-m888 sam-m888 closed this Sep 19, 2015
vores8 pushed a commit to vores8/gramps that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants