Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NarrativeWeb: dates not localised in place pages #916

Merged
merged 2 commits into from Oct 16, 2019

Conversation

SNoiraud
Copy link
Member

@SNoiraud SNoiraud commented Sep 29, 2019

Home link translated to lowercase

Fixes #11357, #11358

@SNoiraud SNoiraud added the bug label Sep 29, 2019
@codecov-io
Copy link

codecov-io commented Sep 29, 2019

Codecov Report

Merging #916 into maintenance/gramps51 will increase coverage by 0.02%.
The diff coverage is 92.3%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           maintenance/gramps51     #916      +/-   ##
========================================================
+ Coverage                 41.92%   41.95%   +0.02%     
========================================================
  Files                      1066     1066              
  Lines                    144874   144972      +98     
========================================================
+ Hits                      60745    60824      +79     
- Misses                    84129    84148      +19
Impacted Files Coverage Δ
gramps/plugins/webreport/narrativeweb.py 77.4% <100%> (+0.05%) ⬆️
gramps/plugins/webreport/webcal.py 79.18% <100%> (+0.02%) ⬆️
gramps/plugins/webreport/basepage.py 55.08% <90%> (+0.38%) ⬆️
gramps/gen/lib/date.py 76.18% <0%> (-0.11%) ⬇️
gramps/plugins/tool/reorderids.py 0% <0%> (ø) ⬆️
gramps/plugins/graph/gvrelgraph.py 0% <0%> (ø) ⬆️
gramps/plugins/graph/gvhourglass.py 0% <0%> (ø) ⬆️
gramps/gui/configure.py 0% <0%> (ø) ⬆️
gramps/plugins/graph/gvfamilylines.py 0% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e2e09...605109c. Read the comment docs.

@SNoiraud SNoiraud added this to the v5.1 milestone Sep 29, 2019
@sam-m888 sam-m888 merged commit 2aa6b54 into gramps-project:maintenance/gramps51 Oct 16, 2019
@sam-m888
Copy link
Member

Thank you

@SNoiraud SNoiraud deleted the B11357 branch December 15, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants