New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update POTFILES.in/skip for missing translations #918
Conversation
Codecov Report
@@ Coverage Diff @@
## maintenance/gramps51 #918 +/- ##
========================================================
- Coverage 41.92% 41.85% -0.08%
========================================================
Files 1066 1066
Lines 144874 145682 +808
========================================================
+ Hits 60745 60977 +232
- Misses 84129 84705 +576
Continue to review full report at Codecov.
|
Note, if "Full" string is not translated, the hardcoded string will be stored on 'place_format.xml' file without "en" lang code. Maybe 'fmt.language' might be used for a 'place_format.xml' file update or as key filter?
I suppose that now (with a complete translation for my locale), it will be something like:
|
Ah, to create a new 'place_format.xml' just ignores the lang code!
Maybe at least set a format language for avoiding handling issues in the future? |
@romjerome Is this good to go, your comments while related don't impact this PR right? You can raise an issue if you need regarding pace_formal.xml |
@sam-m888 it is indirectly related! While entry on localized files is not translated (e.g., during devel stage) Note, the entry already exists on translation template:
So, it could be a minor additionnal issue for most locales and users with an updated translation, otherwise "Full" will be hardcoded for the branch (5.1 -> 5.1.0, 5.1.1, 5.1.2 ,etc ...) |
By renaming (or a temp remove) 'POTFILES.skip', then by running: |
add missing 'removespaces.glade' reference
|
Thank you |
Fix translations being missed in some files by updating POTFILES.in/skip