Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup.py to remove the double '/' when building man pages. #96

Closed
wants to merge 1 commit into from
Closed

Fix setup.py to remove the double '/' when building man pages. #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Expand Up @@ -180,8 +180,8 @@ def build_man(build_cmd):
filename = False

lang = man_dir[8:]
src = build_cmd.build_base + '/data/man/' + lang + '/gramps.1.gz'
target = 'share/man/' + lang + '/man1'
src = build_cmd.build_base + '/data/man' + lang + '/gramps.1.gz'
target = 'share/man' + lang + '/man1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use os.path.join, though I guess man pages will not be built on Windows, anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they have been built on windows by me and by the looks of it others.

fdb8704 Update Sphinx files - includes make.bat for windows

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, it makes even more sense to use os.path.join to use the right path separators, right?

data_files.append((target, [src]))

log.info('Compiling %s >> %s.', src, target)
Expand Down