Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix product attribute image square tooltip #234

Conversation

Lurvy
Copy link

@Lurvy Lurvy commented Jan 29, 2022

Type: bugfix

Issue

When product attribute control type was image square,and if you setted additional fee not 0 for options,then there wasn't shown tooltips when mouse hover image square options in product details page.

Solution

Add missing id for image square

Breaking changes

Testing

  1. Add product attribute for one product,and set control type to image square.
  2. Add option for the product attribute,and set additional fee not 0.
  3. Show product details in shop page,move mouse hover the image square option.

@KrzysztofPajak
Copy link
Member

@Lurvy Thank you for contributing!

@KrzysztofPajak KrzysztofPajak merged commit 98ca005 into grandnode:1.1.X Jan 31, 2022
@KrzysztofPajak KrzysztofPajak added this to Done in GrandNode 2.X Jan 31, 2022
@Lurvy Lurvy deleted the fix-product-attribute-image-square-tooltip branch February 14, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants