Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-405 : Orders search with OrderNumber field #406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SunilParisi123
Copy link
Contributor

Issue-405 : Orders search with OrderNumber field

Resolves #issueNumber
Type: feature|bugfix|

Issue

Description of the issue this PR is solving, why it's happening, and how to reproduce it.

Solution

Summarize your solution to the problem. Please include short description.

Breaking changes

If you have a breaking changes, list them here, otherwise list none.

Testing

  1. List the steps needed for testing your PR.
  2. Assume that everyone already know how to run the GrandNode, and do the basic configuration.
  3. Be detailed enough that someone can work through it easily.

Issue-405 : Orders search with OrderNumber field
@SunilParisi123
Copy link
Contributor Author

Issue: #405

@Nikhil13x
Copy link
Contributor

@KrzysztofPajak Can this be included?

@SunilParisi123
Copy link
Contributor Author

When we want to Filter the orders using OrderNumber (which customers will be aware of mainly) and this is not part of the search handler. When customer is having multiple orders and want to filter that using OrderNumber currently it's not supported in Order Service (GetOrderHandler). So this PR is for that to extend the search including OrderNumber too.

@KrzysztofPajak
Copy link
Member

@Nikhil13x, @SunilParisi123 Interface IOrderService has a method GetOrderByNumber why you don't want to use it ?

@SunilParisi123
Copy link
Contributor Author

@Nikhil13x, @SunilParisi123 Interface IOrderService has a method GetOrderByNumber why you don't want to use it ?

@KrzysztofPajak We wanted to show orders as Autocomplete list and wanted to show all the orders starting with the matching number.

@KrzysztofPajak
Copy link
Member

@Nikhil13x when you limit to ordernumber you should get only one record. So I would like to recommend to use method GetOrderByNumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants