Comment out export * statements

[pozhidaevak]

Export statements like export * from "file" should be commented out as they are translated to code with require() that is not supported by google script
However export val and export function seem to work fine.

@grant also suggested to comment out __export()

Will try to create a PR for this issue...

[pozhidaevak]

@grant , can you please explain why __export() should be also commented?
In my case __export() apears only after translation. Are there cases there it can be used before translation?
I added commenting of only export ... from ... and it works fine

v--TS--v
export * from 'file'
–––
var exports = exports || {};
var module = module || { exports: exports };
// export * from 'file'
 ^--GS--^

[grant]

@pozhidaevak I'm really not sure what the case would be. __export is not valid in Apps Script of course.

Can you provide example expected INPUT and OUTPUT code?

[pozhidaevak]

@grant It is kind of follow up of this issue
On that issue, you suggested to comment __export but __export is actually in the OUTPUT when export is in INPUT. So I don't see why __export should be commented... I think there is no use case for __export be in the input. But I'm new to js so I may be wrong...
Both input and output are presented in original issue

[grant]

So ts2gas work like:

• Take ts
• Transpile to gs
• Add this line to fix export errors:

var exports = exports || {};
var module = module || { exports: exports };

I think we may need to additionally test that export * transpiling works.

• Add some tests
• Add any necessary transforms.

[pozhidaevak]

@grant , I thought you were ok with me just commenting out export * in input for ts2gas.
Here is how it looks:

v--TS--v
export * from 'file'
–––
var exports = exports || {};
var module = module || { exports: exports };
function __export(m) {
    for (var p in m) if (!exports.hasOwnProperty(p)) exports[p] = m[p];
}

__export(require("file"));
 ^--GS--^

the result is not valid due to require()

so I want to make it look like

v--TS--v
export * from 'file'
–––
var exports = exports || {};
var module = module || { exports: exports };
// export * from 'file'
 ^--GS--^

[grant]

@pozhidaevak, Yes, commenting export * before transpiling sounds good. I haven't tried it.

[grant]

Published with ca542f2.