Changed install_plugins() to allow remote installation without local plugins #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install_plugins() will now let you finish remote installation even if bcvi has no local plugins.
grantm
added a commit
that referenced
this pull request
Mar 23, 2014
Changed install_plugins() to allow remote installation without local plugins
|
Good catch - thanks for the contribution. |
grantm
added a commit
that referenced
this pull request
Mar 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 953 in install_plugins() previously returned 0 if there were no local plugins to remotely install. In 3.07, this had no effect, but in 3.08 this causes the chain of functions performing the remote installation to fail prematurely without remotely installing aliases.
Since bcvi can operate without plugins, this patch allows users without local bcvi plugins to perform remote installations.