Skip to content

Commit

Permalink
Fix test polluting other tests
Browse files Browse the repository at this point in the history
  • Loading branch information
grantmcconnaughey committed Jan 4, 2020
1 parent c6ce93e commit 181b27a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 3 additions & 3 deletions field_history/tracker.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ def finalize_class(self, sender, **kwargs):
def initialize_tracker(self, sender, instance, **kwargs):
if not isinstance(instance, self.model_class):
return # Only init instances of given model (including children)
self._inititalize_tracker(instance)
self._initialize_tracker(instance)
self.patch_save(instance)

def _inititalize_tracker(self, instance):
def _initialize_tracker(self, instance):
tracker = self.tracker_class(instance, self.fields)
setattr(instance, self.attname, tracker)
tracker.set_saved_fields()
Expand Down Expand Up @@ -114,7 +114,7 @@ def save(**kwargs):
FieldHistory.objects.bulk_create(field_histories)

# Update tracker in case this model is saved again
self._inititalize_tracker(instance)
self._initialize_tracker(instance)

return ret
instance.save = save
Expand Down
4 changes: 4 additions & 0 deletions tests/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
except ImportError:
import six
from field_history.models import FieldHistory, instantiate_object_id_field
from field_history.tracker import FieldHistoryTracker

from .models import Human, Owner, Person, Pet, PizzaOrder

Expand Down Expand Up @@ -119,6 +120,9 @@ def test_field_history_user_is_from_request_user(self):
self.assertIsNotNone(history.date_created)
self.assertEqual(history.user, user)

# Don't pollute future tests
FieldHistoryTracker.thread.request = None

def test_updated_object_creates_additional_field_history(self):
person = Person.objects.create(name='Initial Name')

Expand Down

0 comments on commit 181b27a

Please sign in to comment.