Support missing types. Closes #26.

grantmcdermott · Apr 15, 2023 · 40a1aee · 40a1aee
1 parent 0f4e1f9
commit 40a1aee
Show file tree

Hide file tree

Showing 11 changed files with 880 additions and 2 deletions.
diff --git a/R/by_aesthetics.R b/R/by_aesthetics.R
@@ -85,7 +85,7 @@ by_pch = function(ngrps, type, pch) {
 by_lty = function(ngrps, type, lty) {
 
   # don't care about line type, return NULL
-  if (!type %in% c("l", "b", "o")) {
+  if (!type %in% c("l", "b", "o", "c", "h", "s", "S")) {
     out = NULL
 
   # NULL -> solid line

diff --git a/R/plot2.R b/R/plot2.R
@@ -399,7 +399,7 @@ plot2.default = function(
       )
     )
   }
-  if (type %in% c("l", "o", "b")) {
+  if (type %in% c("l", "o", "b", "c", "h", "s", "S")) {
     invisible(
       lapply(
         seq_along(split_data),

diff --git a/inst/tinytest/_tinysnapshot/type_c.svg b/inst/tinytest/_tinysnapshot/type_c.svg