-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wishlist: Global options #33
Comments
My current thinking: Add a So, for example, |
Is For instance, I create a new plot (not necessarily) based on Also, something like Love the PKG btw! Big fan of base R graphics and constantly annoyed by the difficulty of plotting legend. |
- Related to a larger goal (#33). But right now to help solve the add=TRUE misalignment with faceted plots.
Hi @J-Moravec sorry for being slow; this issue has been on the backburner. I’m going to turn my attention to it once #83 is merged (since that actually introduces Tbh I’m strongly inclined towards hard coding the par2 fields, since this would give us better control. No promises, but maybe if you can give some concrete examples I’ll reconsider? Thanks for kind words about the package! |
* Basic facet support - Currently only single variable (row) * Better facet support for density objects * Comment for self * Fix x ordering for facet plots * Fix faceting for density plots when facet = "by" * Tweak "by" arg definition * Better comments * xlab and ylab should be part of global titles logic, even with facets * Update tests - To catch simple changes in plotting order * Add plot2 options - Related to a larger goal (#33). But right now to help solve the add=TRUE misalignment with faceted plots. * Catch for add=TRUE with faceted plots - Also fixes custom user mfrow setting override. * Catch if facet = "by" and by isn't a factor * Add facet tests * clean up * Fix local checks * Catches for CI tests with dev R - Grid lines are going to change slightly * Add facet example to README * Update examples * NEWS and version bump * Add facet example to vignette * Website + docs * Website + docs * Ignore build cruft * Attempt fix for CI release case
Closing, since the scaffolding for this now exists via At the moment, only a few global options are supported. I also haven't integrated the forward passing of arguments from Please feel free to raise suggestions for the specific |
Allow users to set things outside of
par
.Palette defaults would be an obvious candidate.(Not true: Should be viapalette
as per #44). Maybe default legend position. Other "theme" options likegrid
andframe.plot
. Any others?The text was updated successfully, but these errors were encountered: