Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Tests #17

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix Broken Tests #17

merged 2 commits into from
May 29, 2024

Conversation

grantwforsythe
Copy link
Owner

Pull Request Template

Title

Fix the broken unit and e2e tests that I broke awhile ago.

Copy link

cypress bot commented May 29, 2024

Passing run #4 ↗︎

0 8 0 0 Flakiness 0

Details:

Merge 90bc83a into 3ff078e...
Project: Default Project Commit: ca706f9afd ℹ️
Status: Passed Duration: 00:08 💡
Started: May 29, 2024 12:33 PM Ended: May 29, 2024 12:33 PM

Review all test suite changes for PR #17 ↗︎

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (7b74495) to head (2c838c2).
Report is 2 commits behind head on main.

Current head 2c838c2 differs from pull request most recent head 90bc83a

Please upload reports for the commit 90bc83a to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          20       20           
  Lines         251      251           
  Branches       20       20           
=======================================
  Hits          243      243           
  Misses          5        5           
  Partials        3        3           

@grantwforsythe grantwforsythe merged commit e0a29ea into main May 29, 2024
7 checks passed
@grantwforsythe grantwforsythe deleted the test/fix-broken-jobs branch May 29, 2024 12:33
Copy link

cypress bot commented May 29, 2024

Passing run #5 ↗︎

0 8 0 0 Flakiness 0

Details:

test: fix broken tests (#17)
Project: Default Project Commit: e0a29ea274
Status: Passed Duration: 00:17 💡
Started: May 29, 2024 12:35 PM Ended: May 29, 2024 12:35 PM

Review all test suite changes for PR #17 ↗︎

grantwforsythe added a commit that referenced this pull request May 29, 2024
* fix broken unit tests
* fix broken e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant