Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 mig account invoice supplierinfo update standard price #17

Conversation

legalsylvain
Copy link
Member

@legalsylvain legalsylvain commented Nov 28, 2019

ça devrait être good, là.

@legalsylvain legalsylvain force-pushed the 12.0-MIG-account_invoice_supplierinfo_update_standard_price branch from ef32e88 to 5e4afce Compare January 7, 2020 16:04
@coveralls
Copy link

coveralls commented Jan 8, 2020

Pull Request Test Coverage Report for Build 213

  • 16 of 18 (88.89%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.6%) to 76.667%

Changes Missing Coverage Covered Lines Changed/Added Lines %
account_invoice_supplierinfo_update_standard_price/models/account_invoice_line.py 6 8 75.0%
Totals Coverage Status
Change from base Build 211: 5.6%
Covered Lines: 184
Relevant Lines: 240

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #17 into 12.0 will decrease coverage by 8.93%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0      #17      +/-   ##
==========================================
- Coverage   81.25%   72.31%   -8.94%     
==========================================
  Files           3       72      +69     
  Lines          32     1723    +1691     
==========================================
+ Hits           26     1246    +1220     
- Misses          6      477     +471     
Impacted Files Coverage Δ
...nvoice_supplierinfo_update_standard_price/hooks.py 100.00% <ø> (ø)
...date_standard_price/models/account_invoice_line.py 69.23% <75.00%> (ø)
...fo_update_standard_price/models/account_invoice.py 100.00% <100.00%> (ø)
...o_update_standard_price/models/product_template.py 100.00% <100.00%> (ø)
...price/wizard/wizard_update_invoice_supplierinfo.py 100.00% <100.00%> (ø)
.../wizard/wizard_update_invoice_supplierinfo_line.py 100.00% <100.00%> (ø)
recurring_consignment_sale/models/sale_order.py 85.71% <0.00%> (ø)
product_food/models/product_category.py 90.90% <0.00%> (ø)
product_food/models/product_allergen.py 87.50% <0.00%> (ø)
...urring_consignment_sale/models/product_template.py 92.85% <0.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f50dce...87d9fbe. Read the comment docs.

@legalsylvain legalsylvain force-pushed the 12.0-MIG-account_invoice_supplierinfo_update_standard_price branch from c049492 to aa9d8bd Compare January 14, 2020 11:34
@mclaeysb
Copy link

mclaeysb commented Apr 8, 2020

Trying to install this branch, but the module depends on account_invoice_supplierinfo_update_triple_discount, which doesn't seem to have been ported from v8 to v12 yet?

@legalsylvain legalsylvain force-pushed the 12.0-MIG-account_invoice_supplierinfo_update_standard_price branch from aa9d8bd to 08eb762 Compare May 24, 2020 21:28
@legalsylvain
Copy link
Member Author

legalsylvain commented May 24, 2020

Hi @mclaeysb. I missed your comment sorry. the module is here : OCA/account-invoicing#579

It just miss a review. Could you review it ?

thanks !

@legalsylvain legalsylvain force-pushed the 12.0-MIG-account_invoice_supplierinfo_update_standard_price branch from 08eb762 to 87d9fbe Compare May 30, 2020 18:33
@legalsylvain
Copy link
Member Author

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-17-by-legalsylvain-bump-patch, awaiting test results.

@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 95d5485. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants