[REF] TEST CI #217
[REF] TEST CI #217
Conversation
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-217-by-legalsylvain-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-217-by-legalsylvain-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-217-by-legalsylvain-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
test-requirements.txt
Outdated
|
|
||
| # https://github.com/OCA/purchase-workflow/pull/1185 | ||
| git+https://github.com/legalsylvain/purchase-workflow@12.0-purchase_xxx_discount-apply-default-value#subdirectory=setup/purchase_discount | ||
| git+https://github.com/legalsylvain/purchase-workflow@12.0-purchase_xxx_discount-apply-default-value#subdirectory=setup/purchase_triple_discount |
There was a problem hiding this comment.
Note this works too and helps removing a comment. For PRs you control this might be useful. For PR you don't control, the drawback is less stability in case the author rebases or something.
| git+https://github.com/legalsylvain/purchase-workflow@12.0-purchase_xxx_discount-apply-default-value#subdirectory=setup/purchase_triple_discount | |
| git+https://github.com/OCA/purchase-workflow@refs/pull/1185/head#subdirectory=setup/purchase_triple_discount |
There was a problem hiding this comment.
thanks a lot for taking time to take a look on my CI problems !
For PR I don't control (quite theoritical case, it doesn't occure in fact), if I understand correctly git / github, comparing :
A) git+https://github.com/acsone/purchase-workflow@12.0-BRANCH-NAME#subdirectory=setup/MODULE
B) git+https://github.com/OCA/purchase-workflow@refs/pull/xxx/head#subdirectory=setup/MODULE
if acsone delete the branch 12.0-BRANCH-NAME, B should still work (event if the PR is closed) but A will fail, right ?
Second question, I have a lot of dependency in that repo, of my incubator repo. It seems it take a while to fetch all the code on the github CI with such requirements :
git+https://github.com/grap/grap-odoo-incubator@12.0#subdirectory=setup/name_search_reset_res_partner
git+https://github.com/grap/grap-odoo-incubator@12.0#subdirectory=setup/purchase_package_qty
git+https://github.com/grap/grap-odoo-incubator@12.0#subdirectory=setup/mobile_kiosk_abstract
do you know if there are a syntax to do something like that, to fetch many modules ?
git+https://github.com/grap/grap-odoo-incubator@12.0#subdirectory=setup/name_search_reset_res_partner,setup/purchase_package_qty,setup/mobile_kiosk_abstract
There was a problem hiding this comment.
if acsone delete the branch 12.0-BRANCH-NAME, B should still work (event if the PR is closed) but A will fail, right ?
Yes that is correct. Although with B you are still at risk of acsone changing the PR with commits you don't want.
Second question, I have a lot of dependency in that repo, of my incubator repo. It seems it take a while to fetch all the code on the github CI with such requirements :
Yes I'm aware of that. I had an optimization that broke with v15 and that I need to re-do.
Codecov Report
@@ Coverage Diff @@
## 12.0 #217 +/- ##
==========================================
+ Coverage 72.79% 75.60% +2.80%
==========================================
Files 94 117 +23
Lines 794 910 +116
Branches 0 169 +169
==========================================
+ Hits 578 688 +110
- Misses 216 217 +1
- Partials 0 5 +5
Continue to review full report at Codecov.
|
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 4020219. Thanks a lot for contributing to grap. ❤️ |
No description provided.