[12.0][FIX] fix product.template related fields #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make product.template.product_variant_id a stored computed field to avoid the following error when setting the print_category_id or to_print related fields: "non-stored field product.template.product_variant_id cannot be searched."
|
Hello @huguesdk ! Je vais laisser la PR ouverte. la cible c'est désormais la V16, ou j'ai mis le module dans l'OCA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 12.0 #173 +/- ##
=======================================
Coverage 85.62% 85.62%
=======================================
Files 149 149
Lines 2330 2331 +1
Branches 360 360
=======================================
+ Hits 1995 1996 +1
Misses 266 266
Partials 69 69 ☔ View full report in Codecov by Sentry. |
|
ok, fine for me. i’ll test and create a similar pr for version 16 on the oca repo then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make
product.template.product_variant_ida stored computed field to avoid the following error when setting theprint_category_idorto_printrelated fields: