Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-company style #22

Closed
wants to merge 3 commits into from
Closed

Conversation

flachica
Copy link
Contributor

@flachica flachica commented Aug 9, 2020

Following this guide

@legalsylvain
Copy link
Collaborator

Hi thanks !

  1. could you fix trivial flake error ? (https://travis-ci.org/github/grap/odoo-module-migrator/builds/716271995#L262)
  2. could you add tests, to make sure it is working correctly ? (you have to add a sample in the folder of the module 8.0 (here), and then, add the expected result in the module 13.0 (here)

thanks !

@flachica flachica force-pushed the fix_multicompany branch 2 times, most recently from 8db7104 to a267cdf Compare August 11, 2020 16:25
legalsylvain and others added 2 commits August 11, 2020 18:40
  in the roadmap)
* [IMP] Add --no-verify option in ``git commit`` to avoid to fail if pre-commit
  is present
* [REF] Refactor ``_execute_shell`` function
@flachica
Copy link
Contributor Author

I think that it is correct now. I think that in this PR is solved with double combination of data element

@legalsylvain
Copy link
Collaborator

Hi @flachica. Thanks a lot for your investment in this project. For the time being, I'm on Hollidays. I'm back in september and take a look on all the PRs. Please ping me at this time, if I forget ;-)
Have a nice summer.

note : I think there are some troubles in your PR. (need rebase, unrelated commits, etc.) could you take a look ?

kind regards.

@flachica
Copy link
Contributor Author

I have several medium-sized projects to migrate and I have decided to use and improve where I can. Thanks to you for creating this. We are in touch

@flachica flachica closed this Aug 14, 2020
@flachica flachica deleted the fix_multicompany branch August 14, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants