Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pre-commit #29

Closed
wants to merge 1 commit into from
Closed

Conversation

flachica
Copy link
Contributor

@flachica flachica commented Aug 15, 2020

Include pre-commit to run before PR in this repository

Copy link
Member

@yelizariev yelizariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you make github actions to run pre-commit check automatically in PRs

@@ -1 +0,0 @@
from . import migration_scripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain it?

@yelizariev
Copy link
Member

Maybe you can close #25 in favor of this one?

@flachica
Copy link
Contributor Author

@yelizariev Yes, but I thought better not to include pre-commit. If it is not executed, you can see much better the changes made by odoo-module-migrator. Also, the programmer could execute pre-commit manually or automatically if he has the script installed

@flachica flachica closed this Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants