Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APM instrumentation #19

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Add APM instrumentation #19

merged 1 commit into from
Jul 20, 2020

Conversation

axw
Copy link
Collaborator

@axw axw commented Jul 17, 2020

Added APM instrumentation to the HTTP server and background archive task, including outgoing requests to zoom and google. (Added while trying to debug an issue where zat failed to download from Zoom.)

image

Copy link
Owner

@graphaelli graphaelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've wanted this for so long, thanks!

@graphaelli
Copy link
Owner

Did you track down the download failure?

@axw
Copy link
Collaborator Author

axw commented Jul 20, 2020

Did you track down the download failure?

I did not. Was some kind of auth issue, probably didn't have the right oauth scopes. I'll come back to it later.

@axw axw merged commit 01b3241 into graphaelli:master Jul 20, 2020
@axw axw deleted the apm branch July 20, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants