Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses two issues:
No default opset version defined for domain 'ai.graphcore.pea'
. This seems to be happening since the 3.2 update, and does not occur in tests. Running under gdb, seems to be triggered by shape inference and the non-extensibility of PopART'sIr::getDefaultOpsetVersion
. I'm not sure if this might hit other custom ops using the "ai.graphcore.pea" domain, or if there is a better workaround than just reverting to "ai.graphcore".appendAttributes
/appendOutlineAttributes
, we get spurious cache hits "every SpMM is the same".Full error: