Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications should open PWA #464

Closed
shift18 opened this issue Mar 2, 2024 · 6 comments
Closed

Notifications should open PWA #464

shift18 opened this issue Mar 2, 2024 · 6 comments

Comments

@shift18
Copy link

shift18 commented Mar 2, 2024

When a PWA creates a notification and this notification is pressed it opens as a tab in the browser, I'd prefer if it opens inside the PWA instead

If a PWA is installed using the chromium based browser brave then notifications opens inside the PWA as expected -- This makes me believe that my preferred behavior indeed is implementable in Vanadium

P.S.
I've only tested this with the twitter PWA.

@quh4gko8
Copy link
Member

quh4gko8 commented Mar 9, 2024

Have you checked this behavior in Chrome and other Chromium-based browsers?

@shift18
Copy link
Author

shift18 commented Mar 9, 2024

No, Besides Vanadium I've only checked brave.

I'll check some more chromium based browsers when i have time.

@shift18
Copy link
Author

shift18 commented Mar 11, 2024

I've checked some more PWA's to see how notifications work.
I found the notification experience inconsistent, for some PWA's notifications always seems to open the PWA and for some they sometimes open the PWA and sometimes they just open in Vanadium.

I also compared Vanadium to brave with the same PWA' s --in brave the notifications always open in the PWA.

@shift18
Copy link
Author

shift18 commented Mar 11, 2024

Im going check chrome next.

@shift18
Copy link
Author

shift18 commented Mar 11, 2024

I've now checked chrome and edge, they handle notifications with PWA's installed in exactly same way as Vanadium on the three PWA'S/sites that I've tested.

I suppose the only lingering question is, why do twitter notifications open in the PWA if installed with brave, but in a tab when installed using Vanadium?

@shift18 shift18 closed this as completed Mar 11, 2024
@shift18 shift18 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@shift18
Copy link
Author

shift18 commented Mar 11, 2024

Can't seem to reproduce my own findings so I'm closing this issue.

Feel free reopen if you experienced the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants