Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacy v3 compatibility #2

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Spacy v3 compatibility #2

merged 2 commits into from
Apr 14, 2021

Conversation

buhrmann
Copy link
Collaborator

@buhrmann buhrmann commented Feb 19, 2021

Updates:

  • use of component factory
  • simplifies span merging using the PhraseMatchers as_spans parameter
  • fixed edge case of overlapping spans using the built-in filter_spans function
  • formats with black, as suggested in spaCy contribution guidelines (now uses double quotes by default, not sure if this is configured differently in spaCy, couldn't find any corresponding configuration)
  • updates all tests and adds test from Fix span merging explosion/spacymoji#8
  • updates docs with new API

To Do:

  • a couple of more edge cases as mentioned in various issues in the upstream repo

@buhrmann buhrmann merged commit d2cc8b5 into master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants