-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkstyle 8.26 checkstyle/checkstyle.xml ruleset blocks building ongdb #19
Comments
You can disable the checkstyling using the maven option Try running this maven command to build up to the verify stage:
|
That works:
But it isn't documented anywhere. (It's now documented in your comment, which is slightly better than nothing.) If people don't have something specifically against the checkstyle checks, I'd rather merge fixes for them (see #20). And if people are absolutely opposed to checkstyle checks, then the build system should be adjusted so that it doesn't enforce them. |
@jsoref I started a branch (3.5-checkstyle) for fixing up the checkstyle issues. Did your commit resolve all of the checkstyle issues or just a few? I am building through now. If it resolves all of them then we can remove the |
Hmm, I was running My naive assumption is that means it's finished. But I could be wrong if there are some code paths beyond |
That should be right. I have build going now with the flag |
The build fails (a lot)...
Neo4j Version: 3.5.15 -- 35e2c7d
Operating System: macOS 10.14.6
Steps to reproduce
Expected behavior
working neo4j project.
Actual behavior
apply fixes to make it happy, repeat
mvn install
:...
...
...
...
I'm trying to both get the build to pass and to some extent record the errors.
The alternative would be for someone to relax the checkstyle rules so that it doesn't trigger failure. But that's not something I understand well enough to do.
The text was updated successfully, but these errors were encountered: