Skip to content
This repository has been archived by the owner on Dec 21, 2020. It is now read-only.

Moved package to com.graphhopper #42

Merged
merged 3 commits into from Jan 15, 2017
Merged

Conversation

boldtrn
Copy link
Member

@boldtrn boldtrn commented Jan 13, 2017

Fixes #40

This PR changed the package name of the geocoding client.

I changed it to: invokerPackage": "com.graphhopper.geocoding-client
Swagger replaces - with _, so maybe we should just call it geocoding or the 'fullname' directions-api-java-client-geocoding?

What do you think?

BTW: I also included the fix of #41, so maybe we just close #41?

BTW2: Something that I find a bit weird is that when I run mvn clean test verify the tests block appears twice, but I am not sure if this is a local bug or even an issue at atll:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Concurrency config is parallel='methods', perCoreThreadCount=true, threadCount=2, useUnlimitedThreads=false
Running com.graphhopper.geocoding_client.api.GeocodingApiTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.372 sec

@karussell
Copy link
Member

karussell commented Jan 13, 2017

For the route optimization I've picked a separated package "routeopt/client" instead of the "-"?

The BTW2 seems strange, but I made the observation that no "verify" is necessary anymore (also for graphhopper core) to run the integration tests. Maybe here too?

BTW: I also included the fix of #41, so maybe we just close #41?

Sorry, saw this too late and already merged it

@karussell
Copy link
Member

It is "routeopt/client/api"

@boldtrn
Copy link
Member Author

boldtrn commented Jan 13, 2017

Thanks I updated the GeoCoding client package. This looks good now. However the test block still appears twice.

Sorry, saw this too late and already merged it

No problem, will merge the master :).

@karussell
Copy link
Member

Thanks - feel free to merge it!

However the test block still appears twice.

Some issue in the autogenerated pom I guess ... nothing important I think

@boldtrn boldtrn merged commit b510a1d into graphhopper:master Jan 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package io.swagger should be com.graphhopper for Geocoding API
2 participants