Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocomplete selection broken for touch devices on non-mobile view #363

Closed
karussell opened this issue Nov 1, 2023 · 0 comments · Fixed by #364
Closed

autocomplete selection broken for touch devices on non-mobile view #363

karussell opened this issue Nov 1, 2023 · 0 comments · Fixed by #364
Labels
bug Something isn't working mobile

Comments

@karussell
Copy link
Member

karussell commented Nov 1, 2023 •
edited
Loading

The mobile input with autocomplete works flawlessly but for touch devices with bigger screens or on a mobile phone in landscape mode we have a different handling (some onBlur behaviour) to hide the box when clicking outside of the box and with this autocomplete box it is not possible to select one of the suggested items for touch devices.

This was introduced in #357 with a simpler AutocompleteEntry but something is not right there as #354 does not have this problem it seems.

The problem seems that onSelect is not trigger from onClick. Adding onTouchEnd seems to help, but why is then onClick not working?
@karussell karussell added the bug Something isn't working label Nov 1, 2023
karussell added a commit that referenced this issue Nov 1, 2023
@karussell
onClick isn't triggered for touch devices, #363
3c5ca8a
@karussell karussell mentioned this issue Nov 1, 2023
Merged
karussell added a commit that referenced this issue Nov 2, 2023
@karussell
onClick isn't triggered for touch devices (#364)
7950a2f 
* onClick isn't triggered for touch devices, #363

* reintroduce pointerdown workaround but make it explicitely only for mousedown

* use original solution but without setIsCancelled as this prevention does not seem to work
karussell added a commit that referenced this issue Dec 4, 2023
@karussell
fix for touch devices and smallscreen: often input keeps focus after …
14a04f8 
…suggestion is touched, occurred after #363
@karussell karussell mentioned this issue Dec 4, 2023
Merged
karussell added a commit that referenced this issue Dec 4, 2023
@karussell
fix for touch devices and smallscreen: often input keeps focus after …
2340ebb 
…suggestion is touched, occurred after #363 (#366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

onClick isn't triggered for touch devices graphhopper/graphhopper-maps
1 participant
@karussell