-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#44 mobile layout #74
Conversation
* Add autocomplete component to dependencies
# Conflicts: # src/Converters.ts # src/map/Mapbox.ts
…e and normal sidebar
…n component Co-authored-by: name me@timurcelikel.com
Adjust padding for map in Mapbox.ts
Thanks a lot! This is yet another nice update :) This collapsing is my favorite feature as it is a phenomenal simple and nice solution for the space problem on mobile! And especially useful for cases with many via points. Also the alternative route selection is nice already. Have added some things to your list. But maybe we separate some of them from this PR to merge it faster.
What do you mean here?
I think, this is a bit related to #54. |
The icon of the button which expands a routing result is called chevron. It points downwards. But the result opens from the bottom to the top on small screens. So maybe it should point upwards then. Not the most important point I guess. |
…en behind controls Also fix link to www.graphhopper.com
This is good to hear. I'll leave it like this then? I have no good idea yet how to implement a selection on the routeing result list level. |
…een small and expanded search view * Reduce padding aroung graphhopper logo on small screens * Fix loading indicator not being shown which also caused multiple map zooms during route requests
And if we also "uncollapse" the bottom "alternative routes" panel when clicking on it or dragging it? qwant does a similar thing. And once the map is selected again, the panel will collapse again and show only the currently selected route.
For "advertisement purposes" :) at least one link to graphhopper.com would be important. With this separate panel we can also point customers to GraphHopper Maps on how to properly attribute the GraphHopper Directions API usage. But we can also hide the attribution panel on mobile and move the GraphHopper attribution into the newly added map attribution btw: there is now a layout bug that the logo is above the auto complete list (for desktop). |
# Conflicts: # src/map/Mapbox.ts # src/sidebar/Sidebar.tsx # src/sidebar/search/Search.tsx
Also introduce context menu on long touch
That's a very good idea, and that's what e.g. the iOS Maps app does as well. Will open an new issue (#79 ) for this though because I want to merge this PR and I like to split up work into smaller peaces. The Geocoding issues will be fixed in #54
Create issue #80 for this |
…or mobile and desktop view
# Conflicts: # src/map/Mapbox.ts
fixes #44 |
This PR attempts to solve #44 which is supposed to create a mobile friendly layout. The current status should be available here:
http://gh-maps-react.s3-website.eu-central-1.amazonaws.com/
@karussell and @easbar please have a look at the current version to provide some feedback. I assembled a list of things that need to be done before we can mark the issue as finished. Feel free to add items to that list by editing this comment if that's possible
What is still missing:
Selection of alternative routes. Currently one can select an alternative route by touching on the line displayed on the map. This is very hard to achieve though since the touch area is quite small.Button styling for close button on full screen text search. Add "Esc"-button to leave this view too.clear geocoding results when input loses focusflip chevron of Query result to point upwards - maybe replace with something else entirely?scrolling instructions on mobile is somehow not possible in firefoxcan't reproduceselecting a different map on mobile nearly always results in selecting kurviger first before I can open it