Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bike priority determination problem for tag combination of cycleway:left and cycleway:right #2969

Closed
ratrun opened this issue Apr 11, 2024 · 0 comments · Fixed by #2970
Closed
Labels
Milestone

Comments

@ratrun
Copy link
Contributor

ratrun commented Apr 11, 2024

Describe the bug
In case that an edge contains both tags cycleway:left and cycleway:right the better priority should be assigned, but this is currently not the case

This test fails passes:

        way.clearTags();
        way.setTag("highway", "primary");
        way.setTag("cycleway:right", "lane");
        assertPriority(SLIGHT_PREFER, way);

this test currently fails:

        way.clearTags();
        way.setTag("highway", "primary");
        way.setTag("cycleway:right", "lane");
        way.setTag("cycleway:left", "no");
        assertPriority(SLIGHT_PREFER, way);

To Reproduce
See https://community.openstreetmap.org/t/neue-routing-engine-valhalla/7204/55

The route is this one: http://localhost:8989/maps/?point=50.7897%2C6.0958&point=50.7872%2C6.0932&profile=bike&layer=OpenStreetMap

Expected behavior
The primary road should not be left and the gas station detour shall be avoided in this case

System Information

master

Screenshots & Logs

The internally assigned priority for the primary segment is "BAD":

Bildschirmfoto vom 2024-04-11 18-36-56-crop

I'll try to prepare a PR for it

karussell pushed a commit that referenced this issue Apr 15, 2024
…2969 (#2970)

* Add support tag combinations cycleway:left and cycleway:right, fixes #2969

* Include review comments
@karussell karussell added the bug label Apr 15, 2024
@karussell karussell added this to the 9.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants