Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphHopper.setCHEnable vs graph CH state #471

Closed
devemux86 opened this issue Jul 22, 2015 · 6 comments
Closed

GraphHopper.setCHEnable vs graph CH state #471

devemux86 opened this issue Jul 22, 2015 · 6 comments
Labels
Milestone

Comments

@devemux86
Copy link
Contributor

After #447 the setCHEnable(true) works also with non CH graphs, that could be a problem.

We should either configure CH automatically or notify the user about the wrong setting.

See also here for the conversation.

@devemux86 devemux86 changed the title GraphHopper.setCHEnable vs graphs CH state GraphHopper.setCHEnable vs graph CH state Jul 22, 2015
@karussell karussell added the bug label Jul 22, 2015
@karussell karussell added this to the 0.5 milestone Jul 22, 2015
@devemux86
Copy link
Contributor Author

In my mind that's somehow related to #285 "Inspect graph properties".

I mean in the end we should somehow not rely on setter methods for loading a graph.
That could be handled automatically without properties failure for user convenience.

@karussell
Copy link
Member

That is true and should be done :)
But automating this is hard and configuring very easy :)

@devemux86
Copy link
Contributor Author

But automating this is hard and configuring very easy :)

I have to agree to that! :)

@karussell
Copy link
Member

Will be fixed after #464 is merged

@devemux86
Copy link
Contributor Author

Peter after testing, I can confirm that the loading of various graph types is working fine again.

@karussell
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants