Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new getData method to avoid 64bit limit of getFlags #978

Closed
karussell opened this issue Mar 1, 2017 · 1 comment
Closed

Introduce new getData method to avoid 64bit limit of getFlags #978

karussell opened this issue Mar 1, 2017 · 1 comment

Comments

@karussell
Copy link
Member

karussell commented Mar 1, 2017

Open questions

  • int getData(int index) or maybe byte getData(int index) or ByteRef getData(int index) like lucene does similar? int getData would be easy to implement and not that bad.
  • How to do this with Refactoring to reduce set/getFlags usage #472
  • Or should we implement a list of GraphExtension? This would allow more dynamically sized data and optional compression
  • Or just a separate DataAccess nicely integrated in GHStorage

See something already in this branch https://github.com/graphhopper/graphhopper/compare/intsref_refactoring

Best would be if we can avoid getData method and use higher level methods instead.

getFlags would be still necessary as it is the only 'column' where reversing is applied (#728)

Not part of this issue is to change the data type long to byte[] in the OSMReader IMO.

@karussell
Copy link
Member Author

This is done via #1447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant