Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version to open source the Isochrone API #1237

Merged
merged 11 commits into from Apr 23, 2018
Merged

Conversation

karussell
Copy link
Member

@karussell karussell commented Dec 1, 2017

This was already announced a long time ago some other things are moving now and so this might not be the latest and greatest solution, but we have the plan to improve this afterwards step by step :)

TODOs

image

@willcohen
Copy link
Contributor

This code has been working quite well for us so far, thanks so much! Do all five of these steps on the to-do need to happen before this can be merged into the project? How much information do you want documented? It seems like ReachServlet is an excellent contained example of how to use and generate a full isochrone.

@karussell
Copy link
Member Author

karussell commented Feb 21, 2018

Great to hear this!

Do all five of these steps on the to-do need to happen before this can be merged into the project?

Not finally decided

How much information do you want documented?

Also not sure yet. But I want some more javadocs, docs in Java and for the web API.

Signed-off-by: Will Cohen <willcohen@users.noreply.github.com>
Signed-off-by: Will Cohen <willcohen@users.noreply.github.com>
Signed-off-by: Will Cohen <willcohen@users.noreply.github.com>
@karussell karussell added this to the 0.11 milestone Mar 19, 2018
@karussell
Copy link
Member Author

Now that we have merged the dropwizard branch ... @michaz do we have code where this is already dropwizardified? If not, would you @willcohen have interests in contributing some :) ?

@karussell
Copy link
Member Author

Have created #1333 with work from @michaz.

@michaz michaz merged commit 74f3551 into master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants