New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version to open source the Isochrone API #1237

Merged
merged 11 commits into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@karussell
Member

karussell commented Dec 1, 2017

This was already announced a long time ago some other things are moving now and so this might not be the latest and greatest solution, but we have the plan to improve this afterwards step by step :)

TODOs

  • rename package stuff from 'reach' to 'isochrone'
  • write tests for error messages and codes
  • include documentation #1303
  • dropwizardify #1333
  • make UI working too e.g. either via separate asset endpoint or as separate application? #1453
  • make polygon creation faster as creating the points is already super fast! later

image

@willcohen

This comment has been minimized.

Show comment
Hide comment
@willcohen

willcohen Feb 21, 2018

Contributor

This code has been working quite well for us so far, thanks so much! Do all five of these steps on the to-do need to happen before this can be merged into the project? How much information do you want documented? It seems like ReachServlet is an excellent contained example of how to use and generate a full isochrone.

Contributor

willcohen commented Feb 21, 2018

This code has been working quite well for us so far, thanks so much! Do all five of these steps on the to-do need to happen before this can be merged into the project? How much information do you want documented? It seems like ReachServlet is an excellent contained example of how to use and generate a full isochrone.

@karussell

This comment has been minimized.

Show comment
Hide comment
@karussell

karussell Feb 21, 2018

Member

Great to hear this!

Do all five of these steps on the to-do need to happen before this can be merged into the project?

Not finally decided

How much information do you want documented?

Also not sure yet. But I want some more javadocs, docs in Java and for the web API.

Member

karussell commented Feb 21, 2018

Great to hear this!

Do all five of these steps on the to-do need to happen before this can be merged into the project?

Not finally decided

How much information do you want documented?

Also not sure yet. But I want some more javadocs, docs in Java and for the web API.

willcohen added some commits Feb 22, 2018

Merge branch 'master' into isochrone_open_source
Signed-off-by: Will Cohen <willcohen@users.noreply.github.com>
Modify isochrone versioning system after rebasing to master
Signed-off-by: Will Cohen <willcohen@users.noreply.github.com>
com.graphhopper.reach.algorithm -> com.graphhopper.isochrone.algorithm
Signed-off-by: Will Cohen <willcohen@users.noreply.github.com>

willcohen and others added some commits Mar 5, 2018

Additional renames of reach and reachability to isochrone
Signed-off-by: Will Cohen <willcohen@users.noreply.github.com>
Merge pull request #1298 from willcohen/isochrone_open_source
Bringing isochrone_open_source branch up-to-date

@karussell karussell added this to the 0.11 milestone Mar 19, 2018

@karussell

This comment has been minimized.

Show comment
Hide comment
@karussell

karussell Apr 9, 2018

Member

Now that we have merged the dropwizard branch ... @michaz do we have code where this is already dropwizardified? If not, would you @willcohen have interests in contributing some :) ?

Member

karussell commented Apr 9, 2018

Now that we have merged the dropwizard branch ... @michaz do we have code where this is already dropwizardified? If not, would you @willcohen have interests in contributing some :) ?

@karussell

This comment has been minimized.

Show comment
Hide comment
@karussell

karussell Apr 11, 2018

Member

Have created #1333 with work from @michaz.

Member

karussell commented Apr 11, 2018

Have created #1333 with work from @michaz.

@michaz michaz merged commit 74f3551 into master Apr 23, 2018

2 of 5 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
codeclimate 63 issues to fix
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment