Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON dependency to core #1291

Closed
wants to merge 10 commits into from
Closed

Add JSON dependency to core #1291

wants to merge 10 commits into from

Conversation

karussell
Copy link
Member

@karussell karussell commented Feb 20, 2018

As discussed here introducing the JSON dependency in core could make several things less clunky, especially since it seems we need this in #1112 in the core as we use the json format instead of the hacky binary+text mix of StorableProperties. (It will not happen for 0.10)

@karussell
Copy link
Member Author

If JTS is able to read and write geojson on its own we probably don't need to add jackson to the core.

@willcohen
Copy link
Contributor

willcohen commented Feb 22, 2018

I should note that JTS also broke itself into a few modules, so jts-core is the main replacement, and then there's also jts-io-common. They use json-simple under the hood.

@karussell
Copy link
Member Author

Thanks for highlighting this! I think we will then better stay with jackson instead of using the inactive json-simple. (conveyal/gtfs-lib#97 (comment))

@karussell
Copy link
Member Author

Really hard decision, but I think for now we close this and try to keep JSON out of the core. Still unsure.

@karussell karussell closed this May 6, 2018
@michaz michaz mentioned this pull request May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants