Wheelchair routing profile #1726

don-philipe · 2019-09-12T14:07:08Z

This pull request adds a new routing profile for wheelchairs. It takes surfaces and smoothness into account. It mainly uses values and rules from the foot routing profile (as, at least in Germany, wheelchair users are equivalent to pedestrians). But in some cases it is more restrictive.

The icon is just a placeholder. I'm sure there are people who can do that better than me.

karussell

Thanks! See my comments

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

web/src/main/resources/assets/img/wheelchair.svg

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

removed unnecessary comments and code changed handlePriority method be valuable for wheelchair fixed wheelchair svg

don-philipe · 2019-09-24T12:09:52Z

Do I need to do something more, additionally to committing and pushing the requested changes?

karussell · 2019-09-24T12:32:32Z

Thanks! Somehow I wasn't notified about this. Will review in the next hours&days.

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

karussell

I additionally found wheelchair:no or wheelchair:limited - is this already considered? See https://wiki.openstreetmap.org/wiki/Wheelchair_routing#Requirements_for_Wheelchair_Accessible_Routes

Also it really needs two directions support to avoid steep elevation. This is now easy, see Bike2WeightFlagEncoder (new UnsignedDecimalEncodedValue("xy", bits, factor, true))

Also it would be important to consider the slope tag.

Edit: Ok, when viewing the tests it seems skipping surface:sand etc is already skipped. Can you comment on this?

Edit2: Ah, you do not "avoid" these tags them but exclude them. Then it would be better to rename avoidHighwayTags and avoidSurface and avoidSmoothness to excludeXY

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

renamed variables to better reflect their usage exclude steep incline and high kerbs

don-philipe · 2019-09-25T10:26:53Z

I additionally found wheelchair:no or wheelchair:limited - is this already considered? See https://wiki.openstreetmap.org/wiki/Wheelchair_routing#Requirements_for_Wheelchair_Accessible_Routes

wheelchair:no is already considered and the way is then skipped. I added now wheelchair:limited to have lower priority.

Also it really needs two directions support to avoid steep elevation. This is now easy, see Bike2WeightFlagEncoder (new UnsignedDecimalEncodedValue("xy", bits, factor, true))

I'm not sure what you mean with that. Isn't that already be solved by skipping ways that are too steep (see below)? Or do you mean that the speed should be adjusted to the incline?

Also it would be important to consider the slope tag.

As long as the incline tag has a numerical value it can now be evaluated. Ways with incline > 6% will be skipped.

karussell · 2019-09-25T11:15:57Z

I added now wheelchair:limited to have lower priority.

👍

Or do you mean that the speed should be adjusted to the incline?

Yes, but you are right that this is not necessary for a first version

As long as the incline tag has a numerical value it can now be evaluated. Ways with incline > 6% will be skipped.

OSM tags are very rare for this and I would prefer skipping too steep roads via elevation. See here of how we do this for Bike2WeightFlagEncoder

… speed = 0

don-philipe · 2019-09-26T13:04:13Z

OSM tags are very rare for this and I would prefer skipping too steep roads via elevation. See here of how we do this for Bike2WeightFlagEncoder

I assumed, that elevation data from PointList.getElevation() is in percent. Am I right?

Now the applyWayTags() method will slow down speed for inclines between 3 and 6 percent and set speed = 0 for inclines greater than 6 percent (same for decline).

karussell

Thanks for the improvements! Looks better. See my new comments

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

core/src/test/java/com/graphhopper/routing/util/WheelchairFlagEncoderTest.java

karussell · 2019-09-27T12:41:46Z

I assumed, that elevation data from PointList.getElevation() is in percent. Am I right?

It is in meter.

calculate slopes correctly now make two directions for speed encoder configurable for FootFlagEncoder

don-philipe · 2019-10-09T07:55:33Z

Sorry for disturbing you again, but can you please have a look at the changes?

karussell · 2019-10-09T10:07:18Z

Sorry for disturbing you again

Not a problem. Please leave a comment as I do not track of the commits in the PRs, especially I do not know when something is ready etc

Will review this again later. For now can you send us the signed CLA (or just your email address) and add yourself as a contributor in CONTRIBUTORS.md?

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

karussell · 2019-11-13T09:56:24Z

Thanks again :) !

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

cbayerlein · 2019-12-22T15:32:44Z

I managed to enable wheelchair routing thanks to this pull! I think it’s really awesome that wheelchair routing is available. Thank you so much @don-philipe and @karussell !

I wasn’t aware that it’s only in later releases. I used 0.13 first (as described in the quick start guide), now I’m using 1.0-pre13.

Unfortunally, I’m too much of a newbie especially in Java, so I’d need to learn a lot before I can contribute myself :-(. But I’ll definitivly look into it and will see what I can do.

For now I hope it's helpful if I do my best as a test user. I already found some issues. Maybe you can help. e. g. for the following request

http://s7.thalon.me:8989/maps/?point=Brunnenstra%C3%9Fe%2011a%20H%C3%B6hr-Grenzhausen&point=Kirchstr.%20H%C3%B6hr-Grenzhausen&locale=de-DE&vehicle=wheelchair&weighting=fastest&elevation=true&use_miles=false&layer=Omniscale

I get:

Cannot find point 0: 50.439114,7.655696
Cannot find point 1: 50.438526,7.656077

Bike2 and foot routing works for the two points. How can I check what's going wrong and maybe solve the issue?

cbayerlein · 2019-12-22T16:48:22Z

Another issue with this route:

http://s7.thalon.me:8989/maps/?point=L%C3%B6hrstr.%20107%20Koblenz&point=Gem%C3%BCsegasse%20Koblenz&locale=de-DE&vehicle=wheelchair&weighting=fastest&elevation=true&use_miles=false&layer=Omniscale

Going via Bahnhofstr. to avoid Löhrstr. seems odd (I can see no reason), also this strange diversion to cross Am Plan/Altengraben... Plus, at the end(after turning right to Gebrüder-Dommermuth-Weg), there're actually (in rl) steps, as far as I remember.

cbayerlein · 2019-12-22T17:09:43Z

And another one:

http://s7.thalon.me:8989/maps/?point=Weinbergstr.%20Koblenz&point=Pastor-Klein-Str.%20Koblenz&locale=de-DE&vehicle=wheelchair&weighting=fastest&elevation=true&use_miles=false&layer=OpenStreetMap.de

yields "Connection between locations not found" although there is one (long way, but possible).

cbayerlein · 2019-12-22T17:15:17Z

I think the problems can be divided into two causes:

missing data in OSM (nothing we can do here except mapping ourselves)
too restrictive routing - maybe we should loosen up a bit.

What do you think?

cbayerlein

Some input from me as an actual wheelchair user...

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

cbayerlein · 2019-12-23T00:04:23Z

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

+        excludeHighwayTags.add("steps");
+        excludeHighwayTags.add("track");
+
+        excludeSurfaces.add("cobblestone");


I'd prefer not to exclude so strictly. Sometimes, it is unavoidable. Is t possible to give a very bad speed penalty, like 1km/h?

cbayerlein · 2019-12-23T00:07:13Z

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

+        excludeSurfaces.add("gravel");
+        excludeSurfaces.add("sand");
+
+        excludeSmoothness.add("bad");


same as with surfaces. The worse the slower...

cbayerlein · 2019-12-23T00:10:38Z

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

+    private final Set<String> excludeSurfaces = new HashSet<>();
+    private final Set<String> excludeSmoothness = new HashSet<>();
+    private final Set<String> excludeHighwayTags = new HashSet<>();
+    private final int maxInclinePercent = 6;


That's iso norm for ramps, but for ways very restrictive and thus unrealistic. I would raise it to 15, giving it a speed penalty over 6.

cbayerlein · 2019-12-23T00:15:03Z

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

+        excludeHighwayTags.add("primary_link");
+        excludeHighwayTags.add("secondary");
+        excludeHighwayTags.add("secondary_link");
+        excludeHighwayTags.add("tertiary");


Is tertiary a Kreisstraße/Landstraße? Then please don't exclude. Sometimes, that's the only available way in rural areas - except for forrest/agricultural roads (Feldwege), wich are much worse.

cbayerlein · 2019-12-23T00:16:50Z

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

+
+        double eleDelta = pl.getElevation(pl.size() - 1) - prevEle;
+        double elePercent = eleDelta / fullDist2D * 100;
+        int smallInclinePercent = 3;


I'd raise that to 5,giving a speed penalty over 3.

cbayerlein · 2019-12-23T01:14:19Z

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java

+        excludeHighwayTags.add("tertiary");
+        excludeHighwayTags.add("tertiary_link");
+        excludeHighwayTags.add("steps");
+        excludeHighwayTags.add("track");


tracktype=grade1 would be possible

cbayerlein · 2019-12-23T01:19:36Z

Maybe we should add excludeHighwayTags.add("path");

cbayerlein · 2019-12-28T17:57:03Z

In the meantime I changed a bit of code in the WheelchairFlagEncoder and now the links which I posted above produce better results as they point to my GH instance. Basically I removed some restrictions like excluding cobblestones and others which were too strict from my point of view and raised the max slope limit to 15%. The changes are very rudimentary (commenting out lines and replacing 6 with 15 ) and rather suboptimal in a way so that there is a lot of room for improvement. For example it would be better to give a speed penalty to bad surfaces. Unfortunally I didn't have time and knowledge yet to implement that, but at least I wrote some code reviews in regards to this. Maybe we can continue working on that topic. I would be very happy about that and will look more deeply into the matter myself next year. For now Guten Rutsch!

don-philipe added 2 commits September 12, 2019 16:05

add a routing profile for wheelchairs

53b2258

add an icon for wheelchair routing profile in web frontend

618e4a0

don-philipe marked this pull request as ready for review September 16, 2019 10:49

karussell requested changes Sep 16, 2019

View reviewed changes

fixes according to review in PR 1726

91503fa

removed unnecessary comments and code changed handlePriority method be valuable for wheelchair fixed wheelchair svg

karussell reviewed Sep 24, 2019

View reviewed changes

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java Outdated Show resolved Hide resolved

karussell requested changes Sep 24, 2019

View reviewed changes

removed unnecessary variables

2786a28

renamed variables to better reflect their usage exclude steep incline and high kerbs

evaluate elevation to set speed and deny ways that are too steep with…

4e6cce6

… speed = 0

karussell reviewed Sep 27, 2019

View reviewed changes

don-philipe added 3 commits September 30, 2019 15:36

removed deprecated get/setSpeed usage

3a6251b

calculate slopes correctly now make two directions for speed encoder configurable for FootFlagEncoder

Merge branch 'master' into wheelchair

af2ce14

adapt test class to new EncodingManager create method

0d52849

karussell added this to the 1.0 milestone Oct 15, 2019

karussell reviewed Oct 15, 2019

View reviewed changes

karussell added 5 commits October 15, 2019 22:49

master bug fix: use under score

5ed3a9c

allow speedTwoDirections for FootFlagEncoder

65c0ad5

clean up test

3b89f34

minor fix

0758c42

merged master

20913bf

karussell merged commit 556f3c8 into graphhopper:master Nov 13, 2019

karussell reviewed Nov 14, 2019

View reviewed changes

core/src/main/java/com/graphhopper/routing/util/WheelchairFlagEncoder.java Show resolved Hide resolved

don-philipe deleted the wheelchair branch November 28, 2019 15:31

karussell added the new feature label Dec 4, 2019

cbayerlein reviewed Dec 23, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wheelchair routing profile #1726

Wheelchair routing profile #1726

don-philipe commented Sep 12, 2019 •

edited

Loading

karussell left a comment

don-philipe commented Sep 24, 2019

karussell commented Sep 24, 2019

karussell left a comment •

edited

Loading

don-philipe commented Sep 25, 2019

karussell commented Sep 25, 2019

don-philipe commented Sep 26, 2019

karussell left a comment

karussell commented Sep 27, 2019

don-philipe commented Oct 9, 2019

karussell commented Oct 9, 2019

karussell commented Nov 13, 2019

cbayerlein commented Dec 22, 2019

cbayerlein commented Dec 22, 2019

cbayerlein commented Dec 22, 2019

cbayerlein commented Dec 22, 2019

cbayerlein left a comment

cbayerlein Dec 23, 2019

cbayerlein Dec 23, 2019

cbayerlein Dec 23, 2019

cbayerlein Dec 23, 2019

cbayerlein Dec 23, 2019

cbayerlein Dec 23, 2019

cbayerlein commented Dec 23, 2019

cbayerlein commented Dec 28, 2019

Wheelchair routing profile #1726

Wheelchair routing profile #1726

Conversation

don-philipe commented Sep 12, 2019 • edited Loading

karussell left a comment

Choose a reason for hiding this comment

don-philipe commented Sep 24, 2019

karussell commented Sep 24, 2019

karussell left a comment • edited Loading

Choose a reason for hiding this comment

don-philipe commented Sep 25, 2019

karussell commented Sep 25, 2019

don-philipe commented Sep 26, 2019

karussell left a comment

Choose a reason for hiding this comment

karussell commented Sep 27, 2019

don-philipe commented Oct 9, 2019

karussell commented Oct 9, 2019

karussell commented Nov 13, 2019

cbayerlein commented Dec 22, 2019

cbayerlein commented Dec 22, 2019

cbayerlein commented Dec 22, 2019

cbayerlein commented Dec 22, 2019

cbayerlein left a comment

Choose a reason for hiding this comment

cbayerlein Dec 23, 2019

Choose a reason for hiding this comment

cbayerlein Dec 23, 2019

Choose a reason for hiding this comment

cbayerlein Dec 23, 2019

Choose a reason for hiding this comment

cbayerlein Dec 23, 2019

Choose a reason for hiding this comment

cbayerlein Dec 23, 2019

Choose a reason for hiding this comment

cbayerlein Dec 23, 2019

Choose a reason for hiding this comment

cbayerlein commented Dec 23, 2019

cbayerlein commented Dec 28, 2019

don-philipe commented Sep 12, 2019 •

edited

Loading

karussell left a comment •

edited

Loading