New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landmark bugs #1745
Landmark bugs #1745
Conversation
I understand you are already investigating creating an extra I also removed the |
I think (?) one issue here was the test -- there even was a "setGet"-test, but it was rather technical and white-box -- it was basically testing that the bits would be twiddled in the same way the code says they would be twiddled. :-) But the important property -- that the remaining weight must never be over-estimated -- was not tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Minimal fix for the two failing tests in #1687.
The first was already discussed (missing setter for the 'fallback' approximator).
The second one was due to an incorrect treatment of "minned out" "delta" weights. See comment in code.